[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon
2. Create a new workspace and check the console

Expected Result:

Should not show any console error

Actual Result:

Console error appears (Invalid prop reports.report_5370990936798009.writeCapability of value daily supplied to ReportScreenWrapper, expected one of ["all","admins"].
)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.45-8
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-26.at.12.54.33.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690356298944369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01db31db71b4efd7d9
• Upwork Job ID: 1688916131373895680
• Last Price Increase: 2023-08-08

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Console error on create new workspace

What is the root cause of that problem?

We are missing writeCapability param when we call buildOptimisticChatReport here which makes CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY becomes writeCapability param and that is an invalid value for writeCapability and then console error appear

App/src/libs/ReportUtils.js

Lines 2001 to 2013 in 1fac96b

	function buildOptimisticWorkspaceChats(policyID, policyName) {
	const announceChatData = buildOptimisticChatReport(
	[currentUserAccountID],
	CONST.REPORT.WORKSPACE_CHAT_ROOMS.ANNOUNCE,
	CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE,
	policyID,
	CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	false,
	policyName,
	null,
	// #announce contains all policy members so notifying always should be opt-in only.
	CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

What changes do you think we should make in order to solve the problem?

We should add writeCapability param as CONST.REPORT.WRITE_CAPABILITIES.ALL before this line

...
CONST.REPORT.WRITE_CAPABILITIES.ALL,
CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

App/src/libs/ReportUtils.js

Line 2013 in 1fac96b

CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

What alternative solutions did you explore? (Optional)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error for new workspace, request money action & child report navigation

What is the root cause of that problem?

It is a regression from PR #21950 where we have added an extra param writeCapability for the function buildOptimisticChatReport but not passed from all required buildOptimisticChatReport called occurrences.

https://github.com/Expensify/App/pull/21950/files#diff-65c096044d5f69b35bcdec14c99c4fda4580759df9b1a7c36650d58eea276f1dR1763

App/src/libs/ReportUtils.js

Lines 2002 to 2014 in 1fac96b

	const announceChatData = buildOptimisticChatReport(
	[currentUserAccountID],
	CONST.REPORT.WORKSPACE_CHAT_ROOMS.ANNOUNCE,
	CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE,
	policyID,
	CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	false,
	policyName,
	null,
	// #announce contains all policy members so notifying always should be opt-in only.
	CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,
	);

App/src/components/ReportActionItem/MoneyRequestAction.js

Lines 100 to 115 in 1fac96b

	const thread = ReportUtils.buildOptimisticChatReport(
	participantAccountIDs,
	props.translate(ReportActionsUtils.isSentMoneyReportAction(props.action) ? 'iou.threadSentMoneyReportName' : 'iou.threadRequestReportName', {
	formattedAmount: ReportActionsUtils.getFormattedAmount(props.action),
	comment: props.action.originalMessage.comment,
	}),
	'',
	CONST.POLICY.OWNER_EMAIL_FAKE,
	CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	false,
	'',
	undefined,
	CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
	props.action.reportActionID,
	props.requestReportID,
	);

App/src/libs/actions/Report.js

Lines 581 to 593 in 3d22f59

	const newChat = ReportUtils.buildOptimisticChatReport(
	participantAccountIDs,
	lodashGet(parentReportAction, ['message', 0, 'text']),
	lodashGet(parentReport, 'chatType', ''),
	lodashGet(parentReport, 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE),
	CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	false,
	'',
	undefined,
	CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
	parentReportAction.reportActionID,
	parentReportID,
	);

What changes do you think we should make in order to solve the problem?

We need to pass writeCapability param with the correct value in all 3 places.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.