[HOLD for payment 2023-08-03] [$1000] Text 'Hidden' in Details Page does not change language when updating language to Spanish

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Click FAB button
2. Click New Group
3. Search and select new users not interact before
4. Create group
5. Click header of group, Observe the word 'Hidden' below the display name of previously selected non-interactive users
6. Update language to Spanish
7. Click header of group again, observed 'Hidden' untranslated

Expected Result:

'Hidden' is translated correctly

Actual Result:

'Hidden' has not been translated yet

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-11.at.16.58.08.mov

Recording.3552.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689071735934159

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01af2a152b7e858fa7
• Upwork Job ID: 1679134444061982720
2023-07-12
• Automatic offers:
• | | 0
• namhihi237 | Contributor | 25718816
• namhihi237 | Reporter | 25718820

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

by: @namhihi237

Please re-state the problem that we are trying to solve in this issue.

'Hidden' is translated correctly

What is the root cause of that problem?

We are hard coding the text 'Hidden' here ReportParticipantsPage:

App/src/pages/ReportParticipantsPage.js

Lines 61 to 62 in 38890e2

	const userPersonalDetail = lodashGet(personalDetails, accountID, {displayName: personalDetails.displayName || 'Hidden', avatar: ''});
	const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || 'Hidden';

Also, we have the same here:

App/src/libs/PersonalDetailsUtils.js

Line 23 in e5b7e3a

return displayName || defaultValue || 'Hidden';

What changes do you think we should make in order to solve the problem?

Use translate for them:

const getAllParticipants = (report, personalDetails, translate) => {
    const {participantAccountIDs} = report;
    return _.chain(participantAccountIDs)
        .map((accountID, index) => {
            const userPersonalDetail = lodashGet(personalDetails, accountID, {displayName: personalDetails.displayName || translate('common.hidden'), avatar: ''});
            const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || translate('common.hidden');

In ReportParticipantsPage:

return displayName || defaultValue || Localize.translateLocal('common.hidden');

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01af2a152b7e858fa7

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Talha345]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text 'Hidden' is not translated when language is updated.

What is the root cause of that problem?

The text 'Hidden' is hardcoded at various places in the codebase.

What changes do you think we should make in order to solve the problem?

Localization key 'common.hidden' should be used at these places.

What alternative solutions did you explore? (Optional)

None