[HOLD for payment 2023-08-03] [$1000] IOS - The title field is cleared when the Confirm task button is pressed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to New Expensify on an iOS handset
2. Click on + icon
3. Click on assign task
4. Enter title and click on next
5. Enter an assignee
6. Click on Confirm task

Expected Result:

The title field should not be cleared

Actual Result:

The title field is cleared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

title-cleared.1.MP4

ios.ass.task.0107.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688216349574539

[View all open jobs on GitHub](https://github.com/Expensify/App/issues?q=is%3Aopen+is% 3Aissue+label%3A%22Help+Wanted%22)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1a312f3e2545b22
• Upwork Job ID: 1676161673601695744
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aman-atg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title field is cleared when the Confirm task button is pressed

What is the root cause of that problem?

The root cause of the problem is the usage of clearOutTaskInfo here which makes the props.task empty for a few secs.

What changes do you think we should make in order to solve the problem?

We can just remove this line of code which will fix the issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1a312f3e2545b22

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - The title field is cleared when the Confirm task button is pressed

What is the root cause of that problem?

Before dismissing modal clearOutTaskInfo() is called, and dismissing modal is not happening instantly, that's why we can see result of clearOutTaskInfo function

What changes do you think we should make in order to solve the problem?

We can call clearOutTaskInfo when new task component unmounts, this way we make sure that task gets cleared out only when component is removed. We remove clearOutTaskInfo from createTaskAndNavigate function

App/src/pages/tasks/NewTaskPage.js

Line 69 in 754723d

function NewTaskPage(props) {

Like this

    useEffect(() => clearOutTaskInfo, []);

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title field is cleared

What is the root cause of that problem?

We're clearing the task info here after confirming. The screen transition takes some time so we can see the values are cleared.

What changes do you think we should make in order to solve the problem?

We should run the clearOutTaskInfo inside InteractionManager.runAfterInteractions so it only clears the value after the screen transition completes.

What alternative solutions did you explore? (Optional)

Both Title and Description will be benefit from the same fix as well.

Another approach is to:

• Remove the clearOutTaskInfo in here
• define a new ref shouldClearOutTaskInfoOnUnmount in the NewTaskPage

const shouldClearOutTaskInfoOnUnmount = React.useRef(false);

• set it to true when confirming
• on component unmount, check if shouldClearOutTaskInfoOnUnmount.current is true, if yes, clear the task values

useEffect(() => {
        return () => {
            if (shouldClearOutTaskInfoOnUnmount.current) {
                TaskUtils.clearOutTaskInfo();
            }
        }
    }, []);

If we don't use the ref, the task values will be cleared also when going back to previous page, which is not desirable.