[HOLD for payment 2023-08-03] [$1000] Emoji picker's position changes on decreasing the screen size

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Go to any chat > Open Emoji Picker
3. Decrease the screen size like shown in video
4. Notice that emoji picker's position changes

Expected Result :

The emoji picker jumps to the LHN instead of behaving the correct way (as in the second video).

Actual Result :

Emoji picker's position changes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Current:

Screen.Recording.2023-04-18.at.12.31.19.AM.mov

Expected:

Recording.270.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681758191524309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019f4f66f49e6e10ed
• Upwork Job ID: 1676073590122438656
• Last Price Increase: 2023-07-04

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

This is not an issue but expected behaviour due to the screen resizing.

[kadiealexander]

Hey Sophie! The first video in the OP is the one that shows the bug. The emoji picker jumps to the LHN instead of behaving the correct way (as in the second video). This was also reported here but I'm reopening this one instead to ensure the original bug reporter is credited.

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji picker positions itself to the top-left corner of the screen if the window dimensions change.

What is the root cause of that problem?

The anchor referenced by emojiPopoverAnchor.current (EmojiPicker.js) no longer exists. The context menu is used as the anchor, however after clicking "Add reaction" the context menu is closed, thereby removing the anchor and making repositioning based on the anchor position impossible.

App/src/components/EmojiPicker/EmojiPicker.js

Lines 42 to 46 in 5a713dd

	const emojiPopoverDimensionListener = Dimensions.addEventListener('change', () => {
	calculateAnchorPosition(emojiPopoverAnchor.current).then((value) => {
	setEmojiPopoverAnchorPosition(value);
	});
	});

This causes the position to be x=0, y=0.

What changes do you think we should make in order to solve the problem?

We need to use the same anchor that is used by BaseReportActionContextMenu (which is the chat message).

What alternative solutions did you explore? (Optional)

N/A

Originally posted by @samh-nl in #21982 (comment)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019f4f66f49e6e10ed