Skip to content

[HOLD for payment 2023-08-16] [$250] Migrate TextInput/index.js to function component #16208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 51 comments
Closed
1 task

[HOLD for payment 2023-08-16] [$250] Migrate TextInput/index.js to function component #16208

marcaaron opened this issue Mar 20, 2023 · 51 comments
Assignees
@JmillsExpensify @sobitneupane @stitesExpensify @huzaifa-99
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166004e95bef49d66
  • Upwork Job ID: 1685093243067191296
  • Last Price Increase: 2023-07-29
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 6, 2023
@muxriddinmuqimov77
Copy link

I'd like to work on this.

@dhairyasenjaliya
Copy link
Contributor

@muxriddinmuqimov77 do not spam proposals on every migration task (btw all the spammed proposals are on hold no reason to comment)

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

This issue has not been updated in over 14 days. eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jun 22, 2023
@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@ghost
Copy link

ghost commented Jul 15, 2023

Dibs

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@marcaaron marcaaron removed Monthly KSv2 Improvement Item broken or needs improvement. labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@huzaifa-99
Copy link
Contributor

Thanks for the review @sobitneupane. I will wait for assignment to start the pr.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($250)

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @huzaifa-99 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@huzaifa-99
Copy link
Contributor

Thanks for the assignment, PR will be up shortly

@huzaifa-99 huzaifa-99 mentioned this issue Aug 2, 2023
Merged
58 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 2, 2023
@huzaifa-99
Copy link
Contributor

PR is ready for review @sobitneupane

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

🎯 ⚡️ Woah @sobitneupane / @huzaifa-99, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

  • when @huzaifa-99 got assigned: 2023-08-02 17:47:39 Z
  • when the PR got merged: 2023-08-03 21:45:06 UTC

On to the next one 🚀

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 9, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate TextInput/index.js to function component [HOLD for payment 2023-08-16] [$250] Migrate TextInput/index.js to function component Aug 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@huzaifa-99
Copy link
Contributor

Payment still pending.

@huzaifa-99
Copy link
Contributor

Bump on this @JmillsExpensify

@sobitneupane
Copy link
Contributor

Requested payment on newDot.

@huzaifa-99
Copy link
Contributor

Gentle bump on this @JmillsExpensify

1 similar comment
@huzaifa-99
Copy link
Contributor

Gentle bump on this @JmillsExpensify

@JmillsExpensify
Copy link

Payment summary:

@huzaifa-99 offer sent via Upwork posting here: https://www.upwork.com/jobs/~0195dcd8d4931f4536.

@JmillsExpensify
Copy link

$250 payment for @sobitneupane approved via NewDot based on review related to this component.

@huzaifa-99
Copy link
Contributor

@JmillsExpensify Offer accepted, thank you!

@JmillsExpensify
Copy link

All paid out! Going to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmillsExpensify JmillsExpensify

@sobitneupane sobitneupane

@stitesExpensify stitesExpensify

@huzaifa-99 huzaifa-99

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests