[$250] Vertical keyboard padding is shown beneath input when opening chat

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

• Navigate to Settings > Profile
• Tap the 'First name' input field
• Without manually closing the keyboard, close the modal with the 'x' button
• Navigate to any chat

Expected Result:

• There should not be padding beneath the input

Actual Result:

• There is keyboard-sized vertical padding beneath the input

Platform:

Where is this issue occurring?

• iOS: iPhone 7, iOS 13.3

Version Number: v1.2.18-8
Reproducible in staging?: Yes
Reproducible in production?: Yes

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Julesssss]

@flaviadefaria please hold on making this external for now. It seems related to a keyboard refactor that @tgolen is working on, so I'd like to first get his opinion.

[tgolen]

I've added a HOLD to this and added it to the master tracking GH for now. I'll have to take a look at this on my branch and see if it's fixed yet or not.

[flaviadefaria]

@Julesssss should I delete the Upwork post then?

[Julesssss]

Thanks, @tgolen.

@flaviadefaria I'm not sure how UpWork posts work in practice, but I assume it's fine to keep it up for now until it has been confirmed.

[tgolen]

OK, I just tried it out with my branch and it is still broken there. Let's keep this issue on HOLD until my PR is merged though (so we can get proposals based on the right code). If we can't pause the Upwork job, then maybe it is best to delete it for now.

[flaviadefaria]

Oh we're actually good, I confused the GH issues 😅 I had another one with Jules for which I posted the job in Upwork this morning, but I had not posted one for this issue. I'll switch this one to weekly then until it's removed from hold.

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[tgolen]

This is no longer on hold and can have proposals created for it with the new code.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

[Julesssss]

Awaiting proposals

[parasharrajat]

Do we have to worry about iOS 13.3?

[JmillsExpensify]

@flaviadefaria Given that we're still early and no proposals have been accepted, I'm assigning myself per the new BZ process: https://stackoverflow.com/c/expensify/questions/14597/14598#14598.

[JmillsExpensify]

Do we have to worry about iOS 13.3?

That's a great question. I don't think we do or should, as that is quite a ways back in supporting older OS that aren't seeing active development. @Julesssss do we have a list of iOS versions that we officially support? I wouldn't expect this one to be on it, that's 4 years old, right?

[parasharrajat]

I recently faced this issue on iOS 15. This is a very serious issue. Let's prioritize this.

[Julesssss]

do we have a list of iOS versions that we officially support? I wouldn't expect this one to be on it, that's 4 years old, right?

I don't believe we have decided on a specific version and might be using the React native default. Our Android support goes far back also and while we should restrict this eventually it's a separate discussion than needs context on the version market share. Having said that, I don't think we should be blocking devices that are still receiving OS security updates from Apple/Google.

I recently faced this issue on iOS 15. This is a very serious issue. Let's prioritize this.

Anyway, seems like this is occurring on newer devices too 👍

[tgolen]

I think the list of iOS versions that we support is maintained by Applause. I don't think we have it written down anywhere, but if you ask Applause, I'm sure they could tell you the versions they test on (which would be the same as the versions we support).

…

On Thu, Nov 3, 2022 at 4:52 AM Jules ***@***.***> wrote: do we have a list of iOS versions that we officially support? I wouldn't expect this one to be on it, that's 4 years old, right? I don't believe we have. Our Android support goes far back also and while we should restrict this eventually it's a separate discussion than needs context on the version market share. Having said that, I don't think we should be blocking devices that are still receiving OS security updates from Apple/Google. I recently faced this issue on iOS 15. This is a very serious issue. Let's prioritize this. Anyway, seems like this is occurring on newer devices too 👍 — Reply to this email directly, view it on GitHub <#12114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB4FZIYEYOWG26762HTWGOKQFANCNFSM6AAAAAARN24GLQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[JmillsExpensify]

Having said that, I don't think we should be blocking devices that are still receiving OS security updates from Apple/Google.

Nice, I agree with this @Julesssss

I think the list of iOS versions that we support is maintained by Applause.

Thanks @tgolen, I'll ask in QA in Slack

I recently faced this issue on iOS 15. This is a very serious issue. Let's prioritize this.

Agreed @parasharrajat, if it's not limited to older OS, let's fix it.

[JmillsExpensify]

Ok moving on now, I'm not able to reproduce on iOS 16, which is fine, but I kind of wonder if this issue is a dupe of #11858?

[Julesssss]

@JmillsExpensify ah nice spot. That does seem very similar.

[Julesssss]

Closing as a dupe of #11858. I added the screenshot and additional reproduction steps and info to the other issue.

[Julesssss]

@JmillsExpensify or @flaviadefaria would you mind closing the UpWork job? Thanks

[JmillsExpensify]

Cool, cool. Yep all good. I don't think one exists so nothing to close out.