[HOLD for payment 2022-12-09] [$1000] [Bug] mWeb - If you close the keyboard using native back button then it will keep reopening while selecting the contacts - reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Tap on :green-plus-button: > New group
2. Close the keyboard by tapping native back button
3. Select a user

Expected Result:

The keyboard should not open

Actual Result:

The keyboard keeps opening

Workaround:

unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-30.at.6.40.15.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661865140075919

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[RachCHopkins]

I'm still unable to reproduce this. Is this still happening @mvtglobally ?

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[techievivek]

I am able to reproduce this on staging so we can definitely work on this one.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @Beamanator (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

@techievivek just wondering why unassign both you and me? 🤔

[techievivek]

@Beamanator Oops my bad, I didn't mean to unassign you, I did that by mistake. 😞

[Beamanator]

Aah ok no worries :D

[Beamanator]

Hmm I remember hearing we're holding most of these keyboard-related issues for some upcoming "keyboard initiative" - asking in Slack about this before putting it on hold officially

[mananjadhav]

Yeah, we should hold them. This is the issue where we're tagging all Keyboard related issue.

#10273

[s77rt]

Applied in Upwork (50% bonus)
PR is ready

[JmillsExpensify]

@mananjadhav @tgolen PR is ready for ya'll. We still need to get the PR merged for the bonus to apply, though we're on the right track!

[mananjadhav]

PR is reviewed and approved. Just left to merge.

[JmillsExpensify]

Awesome, it looks like we're just waiting on someone to press merge. Who is that going to be?

[mananjadhav]

Awesome, it looks like we're just waiting on someone to press merge. Who is that going to be?

@tgolen Will merge the PR.

[JmillsExpensify]

And the PR is merged!

[JmillsExpensify]

Alright, the PR is merged, so let's circle back on payments. We still need to wait for the regression period to start/end, though this is where we landed:

• Contributor: @s77rt $1,500 (incl. the 50% bonus)
• Contributor+: @mananjadhav $1,500 (incl. the 50% bonus)
• Issuer reporter: @thesahindia $250

All of the above are minimally invited to the Upwork job at this point.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.35-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed: If you close the keyboard using native back button then it will keep reopening while selecting the contacts #13101

If no regressions arise, payment will be issued on 2022-12-09. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @tgolen] The PR that introduced the bug has been identified. Link to the PR: Unable to determine conclusively, see this comment
• [@mananjadhav / @tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@mananjadhav / @tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[JmillsExpensify]

All contributors hired in Upwork. @tgolen @mananjadhav Can you confirm we're all good on the first think items in the checklist above?

[JmillsExpensify]

Hey guys, bump on the BZ list. Mind confirming we're good on those?

[mananjadhav]

@JmillsExpensify I was trying to check the offending PR, but couldn't pinpoint to a proper one. I think this wasn't working since the beginning. How do we link offending PRs in such cases?

[JmillsExpensify]

That's a great question, though I will defer to @tgolen on that one.

[tgolen]

Yeah, I assume there could be situations where the bug existed ever since the code was initially written. In that case, there would still be a source PR for it, right? It would just be the very first PR that introduced the code? Though, I could still see a case where that might be nearly impossible to track down as well.

I think if we give a reasonable effort to find an offending PR, and we come up empty, then an exception is probably fine in those cases to not find a source of the regression.

[mananjadhav]

I'll try to take another stab at it over the weekend. Will post an update here.

--

@JmillsExpensify this is ready for payout with a 50% bonus.

[JmillsExpensify]

All paid out.

Alright, the PR is merged, so let's circle back on payments. We still need to wait for the regression period to start/end, though this is where we landed:

• Contributor: @s77rt $1,500 (incl. the 50% bonus)
• Contributor+: @mananjadhav $1,500 (incl. the 50% bonus)
• Issuer reporter: @thesahindia $250

[JmillsExpensify]

@tgolen @mananjadhav can both of you please fill out the BZ checklist above, and when you do, close this issue out? The regression test is a work in progress based on a larger keyboard regression test we'll do across various KAV cases, so that's done for now.

[tgolen]

I'll try to take another stab at it over the weekend. Will post an update here.

@mananjadhav do you have an update on this?

[tgolen]

Bump @mananjadhav

If no response today, I'll just mark that we couldn't locate the specific regression.

[mananjadhav]

Apologies for the delay, was OOO.

I tried checking but the code has gone through multiple refactors, and I am unable to pinpoint as the component used different methods before for setSelection, relatedTarget handling.

#7530
#11673

But I am unable to build and check if it worked properly by reverting these fixes.

[tgolen]

OK, thank you! I'll just put down that it was inconclusive and we couldn't really find a direct source.