Skip to content

Unable to switch default payment #10049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chiragsalian opened this issue Jul 21, 2022 · 4 comments
Closed

Unable to switch default payment #10049

chiragsalian opened this issue Jul 21, 2022 · 4 comments

Comments

@chiragsalian
Copy link
Contributor

Action Performed:

  1. Log into your account. Have a few VBA accounts.
  2. Go to Settings -> Payments.
  3. Open network tab
  4. Select a non default account and attempt to set it as default.

Expected Result:

It should have been corrected set as default.

Actual Result:

Nothing happens, the account is not set as default and there is an error in network tab.
image

Workaround:

None

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.85-6
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@chiragsalian chiragsalian added DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 labels Jul 21, 2022
@chiragsalian chiragsalian self-assigned this Jul 21, 2022
@chiragsalian
Copy link
Contributor Author

The issue is happening on production so its technically not a blocker. But it seems bad enough that if the issue is App related (which is suspect its not) it would be nice to CP it to staging so the fix is available on prod soon.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@chiragsalian
Copy link
Contributor Author

Looks like we found the issue was with gold card wallets - #10021 (comment). Not a deploy blocker, but cc @MariaHCD, when working on the other issue can you look into this one too. I feel like the solution for one will solve both but i want to make sure we don't forget testing this too.

@chiragsalian chiragsalian added Weekly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jul 21, 2022
@chiragsalian chiragsalian removed their assignment Jul 21, 2022
@chiragsalian
Copy link
Contributor Author

Actually maybe we can close it out since if we just implement better error handling then nothing is needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants