Android - Payments - Default payment is disappearing after closed and re-open the app.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Prerequisite: add VBA to the account

1. Launch the app
2. Log in with account
3. Go to Setting - Payments
4. Select Saving account
5. Tap Make default payment method
6. Put your password and Save
7. Close the app
8. Open the app again

Expected Result:

Default payment is not disappearing after closed and re-open the app

Actual Result:

Default payment is disappearing after closed and re-open the app.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.85.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): [email protected]/ Feya86Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220719-104429_New.Expensify.1.mp4

Recording.811.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

seems related to #9828

@MariaHCD the front end code looks good here and the linked Web-E PR is on production.

Will try to look at logs and see if there's any obvious reason why this wouldn't work.

[marcaaron]

Seems to be throwing here:

https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2272d79a1c5ff9305d-LAX%22)+AND+timestamp:[2022-07-19T23:32:50.671Z+TO+2022-07-20T01:32:50.671Z]&index=logs_expensify-017732

Throwing exception with message: '401 No user with that partner/userID/password' from auth/lib/Login.cpp:320

[marcaaron]

@kbecciv are you certain that the password entered is correct? This looks like a normal error that would throw if the password was entered incorrectly and from watching the video I think that might have happened.

[kbecciv]

@marcaaron Yes, password is correct. Just re-test with build 1.1.85.5 and issue is reproduced.
Also noticed the payments list is not displayed when navigate to Payments.
Please attached video.

Screen_Recording_20220720-154538_New.Expensify.mp4

[MariaHCD]

I tested with the same account and looks like there was an issue with setting the default payment method which is why the default badge doesn't stick.

2022-07-21 09:44:46 882 | [email protected] | Cannot find bankAccountID: 0

2022-07-21 09:44:46 882 | [email protected] | [OOPS!] API Threw: Auth SetWalletLinkedAccount returned an error ExpException - 4bbb72ecefead2582ca5df4a9b782afc ~~ message: '404 Bank account not found' 0: '[onyxMethod: 'merge' key: 'userWallet' value: '[error: 'Something went wrong. Please chat with Concierge for further assistance.']']' exceptionMessage: 'Auth SetWalletLinkedAccount returned an error' exceptionFile: '/git/releases/expensify.com/4c925fa/lib/Auth.php' exceptionLine: '117' exceptionCode: '404'

Logs: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2272e2fffc6d40b8fd-DEN%22)+AND+timestamp:[2022-07-21T08:44:46.877Z+TO+2022-07-21T10:44:46.877Z]&index=logs_expensify-017754

Not sure why we're unable to find the bank account, from the logs, it does look like the linkedBankAccountID param is being sent correctly.

[marcaaron]

Ok. So after this conversation in Slack this is most likely happening because tester does not have an active wallet.

https://expensify.slack.com/archives/C03TQ48KC/p1658426458912309

Myself and Chirag both tested these flows with Gold wallets and it works ok. So, I think we need some better error handling. But this is not a deploy blocker.

[MariaHCD]

Thanks for the fix here! Agreed that we'll need better error handling here. In light of this announcement, I'll also have to update the format of the error data sent to the client.

[MariaHCD]

Introducing better error handling here: #10322

Closing in favor of: https://github.com/Expensify/Expensify/issues/216152