Indicate no translation for Nikon lenses #3239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
added
makerNote
neheb
previously approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "(xyz)" notation is used in some other makernotes like Minolta, Sony, Pentax... For Canon we even print "Unknown Lens (xyz)". The parentheses are sometimes used by apps to detect if the pretty printing of the lens model was not successful.
This is also the fallback behavior of
EXV_PRINT_TAG()which is used for some lens tables (e.g. Canon RF mount), so also switching Nikon Z mount lenses to that.