[AT] - update readme with ES Modules instructions #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
approved these changes
Jul 25, 2019
|
Thanks for approving @IDisposable . I don't have write access to this repo so you'll have to merge it :) |
EvanHahn
requested changes
Jul 28, 2019
| @@ -13,6 +13,13 @@ Basic usage | |||
|
|
|||
| This package is available as *humanize-duration* on [npm](https://www.npmjs.com/package/humanize-duration) and Bower. You can also include the JavaScript file in the browser. | |||
|
|
|||
| With `ES Modules`: | |||
There was a problem hiding this comment.
Why is this in quotes and not simply "ECMAScript modules" as text?
| With `ES Modules`: | ||
|
|
||
| ```js | ||
| import * as humanizeDuration from 'humanize-duration'; |
There was a problem hiding this comment.
humanize-duration doesn't actually use ES exports...does this kind of thing work on all build setups?
|
@andrew-c-tran Bumping this. Have you had a chance to look at my comments? |
|
Closing because I haven’t heard back in months. Let me know if that’s wrong and I’m happy to reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Readme.md to contain instructions on how to use package with ES module importer. Addresses issue #153
Verified in Babel 7.4