feat(table): Add selection-display property
#9355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macandcheese
added
figma changes
github-actions
bot
added
the
enhancement
jcfranco
approved these changes
May 17, 2024
packages/calcite-components/src/components/table/table.stories.ts
Outdated
Show resolved
Hide resolved
Merged
benelan
added a commit
that referenced
this pull request
May 17, 2024
…otfix-release * origin/main: chore: release next feat(table): Add `selection-display` property (#9355) refactor(dropdown-item): remove unused css classes (#9349) chore: release next feat(dropdown-item): update spacing of icons (#9330) chore: release next feat(flow-item): add content-top slot (#9344) chore: release next feat(flow-item): add content-bottom slot (#9346) chore: release next fix(input, input-number, input-text): ensure autofocus is available on HTMLElement (#9343) (#9347)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9353
Summary
This adds a
selectionDisplayproperty to Table. It defaults to "top" (the current behavior), and adds a "none" option. This will hide all selection chips and clearance affordances. It will also hide any slotted content inselection-actionsslot, which is noted in the doc.We've planned on adding further customization ability to this selection mode UI (make it sticky, floating on bottom, etc.), and that can still occur as planned #8914, by adding values to this new property.