Skip to content

fix(input-date-picker): update the focus and hover chevron icon color #9146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2024
Merged

fix(input-date-picker): update the focus and hover chevron icon color #9146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
873e528
fix(input-date-picker): updated chevron icon colors to be ui-text-3 w…
aPreciado88 Apr 17, 2024
a55aa92
fix(input-date-picker): updated chevron icon colors to be --calcite-c…
aPreciado88 Apr 18, 2024
4f1b970
fix(input-date-picker): consistent chevron icon color
aPreciado88 Apr 18, 2024
992bceb
Merge branch 'main' of github.com:Esri/calcite-design-system into aPr…
aPreciado88 Apr 18, 2024
a0cd311
fix(input-date-picker): consistent chevron icon color
aPreciado88 Apr 18, 2024
eff55bb
fix(input-date-picker): update the focus and hover chevron icon color
aPreciado88 Apr 19, 2024
0f01b44
Merge branch 'main' of github.com:Esri/calcite-design-system into aPr…
aPreciado88 Apr 22, 2024
97a3eee
Merge branch 'main' of github.com:Esri/calcite-design-system into aPr…
aPreciado88 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/calcite-components/src/components/input-date-picker/input-date-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,18 @@
padding-inline: var(--calcite-toggle-spacing);
}

.chevron-icon-down {
color: var(--calcite-color-text-3);

&:hover {
color: var(--calcite-color-text-1);
}
}

.chevron-icon-up {
color: var(--calcite-color-text-1);
}

:host([range]) {
.input-container {
@apply flex;
Expand Down
1 change: 1 addition & 0 deletions packages/calcite-components/src/components/input-date-picker/input-date-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,7 @@ export class InputDatePicker
// we set tab index to -1 to prevent delegatesFocus from stealing focus before we can set it
<span class={CSS.toggleIcon} tabIndex={-1}>
<calcite-icon
class={open ? "chevron-icon-up" : "chevron-icon-down"}
Copy link
Member

@benelan benelan Apr 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these classes to the CSS object in resources.ts. See two lines above for a usage example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consolidated this css into a single class and added it to resources.ts.

icon={open ? "chevron-up" : "chevron-down"}
scale={getIconScale(this.scale)}
/>
Expand Down