-
Notifications
You must be signed in to change notification settings - Fork 80
docs: improve consistency for component prop descriptions #8580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve consistency for component prop descriptions #8580
Conversation
…into dit13711/7071-make-changes-from-verification-feedback
…iltered items are shown (#8569) **Related Issue:** #8564 ## Summary - Adds slot `"filter-no-results"`. - When filter is enabled, a filter text is present and there are no items being shown, this slot will be displayed - The slot is for showing any warning information that there are no items displayed - Allows a user to customize any messaging for no results shown. - Adds screenshot test - Adds e2e test
https://github.com/Esri/calcite-design-system into dit13711/7071-make-changes-from-verification-feedback
…into dit13711/7071-make-changes-from-verification-feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨🧹📚✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome additions! 🥇
Few nitpicks and follow-up questions for consideration.
packages/calcite-components/src/components/checkbox/checkbox.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/input-time-zone/input-time-zone.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/input-time-zone/input-time-zone.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/shell-panel/shell-panel.tsx
Outdated
Show resolved
Hide resolved
…into dit13711/7071-make-changes-from-verification-feedback
…into dit13711/7071-make-changes-from-verification-feedback
…into dit13711/7071-make-changes-from-verification-feedback
…into dit13711/7071-make-changes-from-verification-feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more lowercase id
refs, and then this LGTM 🚀
packages/calcite-components/src/components/input-number/input-number.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/text-area/text-area.tsx
Outdated
Show resolved
Hide resolved
…ion-message * origin/main: chore: release next docs: improve consistency for component prop descriptions (#8580)
…idation-ui * origin/main: feat(handle, block, list-item): improve drag handle tooltip to include item label (#8584) chore: release next feat: reflect validationIcon property (#8583) chore: release next docs: improve consistency for component prop descriptions (#8580) test(action-menu): skip close on blur test. (#8585) feat(tabs): emit selection-related events when selection is modified after closing the selected tab (#8582)
Related Issue: #7071
Summary
Updates doc consistency across various components defined in the above issue for props, events, methods, and css vars, including:
block-section
checkbox
chip
combobox
fab
input-number
input-time-zone
radio-button
segmented-control
shell-panel
switch
text-area
tile-select
tree