Skip to content

fix(stepper): emits calciteStepperItemChange event when switched to first step #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2023
Merged

fix(stepper): emits calciteStepperItemChange event when switched to first step #8422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ca0b22
fix(stepper): emits calciteStepperItemChange event when switched to f…
anveshmekala Dec 13, 2023
6dd1058
add back support for switching when all items are disabled
anveshmekala Dec 14, 2023
60e033d
Merge branch 'main' into anveshmekala/8397-fix-stepper-change-event-i…
anveshmekala Dec 15, 2023
3e99828
Merge branch 'main' into anveshmekala/8397-fix-stepper-change-event-i…
anveshmekala Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/calcite-components/src/components/stepper/stepper.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,10 @@ describe("calcite-stepper", () => {
it("should emit calciteStepperItemChange on user interaction", async () => {
const page = await newE2EPage();
await page.setContent(html`<calcite-stepper style="width: 100px">
<calcite-stepper-item heading="Step 1" id="step-1" disabled>
<calcite-stepper-item heading="Step 1" id="step-1">
<div>Step 1 content</div>
</calcite-stepper-item>
<calcite-stepper-item heading="Step 2" id="step-2">
<calcite-stepper-item heading="Step 2" id="step-2" disabled>
<div>Step 2 content</div>
</calcite-stepper-item>
<calcite-stepper-item heading="Step 3" id="step-2">
Expand All @@ -811,27 +811,26 @@ describe("calcite-stepper", () => {

const stepper = await page.find("calcite-stepper");
const [actionStart, actionEnd] = await page.findAll("calcite-stepper >>> calcite-action");
const [stepperItem1] = await page.findAll("calcite-stepper-item");
const eventSpy = await stepper.spyOnEvent("calciteStepperItemChange");
expect(eventSpy).toHaveReceivedEventTimes(0);

// shouldn't emit change event when disabled element is visible
await actionEnd.click();
await page.waitForChanges();
expect(eventSpy).toHaveReceivedEventTimes(1);
expect(eventSpy).toHaveReceivedEventTimes(0);

await actionStart.click();
await actionEnd.click();
await page.waitForChanges();
expect(eventSpy).toHaveReceivedEventTimes(2);
expect(eventSpy).toHaveReceivedEventTimes(1);

// shouldn't emit change event when disabled element is visible
stepperItem1.setProperty("disabled", true);
await actionStart.click();
await page.waitForChanges();
expect(eventSpy).toHaveReceivedEventTimes(2);
expect(eventSpy).toHaveReceivedEventTimes(1);

await actionEnd.click();
await actionStart.click();
await page.waitForChanges();
expect(eventSpy).toHaveReceivedEventTimes(3);
expect(eventSpy).toHaveReceivedEventTimes(2);
});
});
});
6 changes: 2 additions & 4 deletions packages/calcite-components/src/components/stepper/stepper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ export class Stepper implements LocalizedComponent, T9nComponent {
* Fires when the active `calcite-stepper-item` changes.
*
*/
@Event({ cancelable: false })
calciteStepperItemChange: EventEmitter<void>;
@Event({ cancelable: false }) calciteStepperItemChange: EventEmitter<void>;

/**
* Fires when the active `calcite-stepper-item` changes.
Expand Down Expand Up @@ -242,7 +241,6 @@ export class Stepper implements LocalizedComponent, T9nComponent {
@Listen("calciteInternalStepperItemSelect")
updateItem(event: CustomEvent): void {
const { position } = event.detail;

if (typeof position === "number") {
this.currentActivePosition = position;
this.selectedItem = event.target as HTMLCalciteStepperItemElement;
Expand Down Expand Up @@ -506,7 +504,7 @@ export class Stepper implements LocalizedComponent, T9nComponent {
}

if (
this.currentActivePosition &&
typeof this.currentActivePosition === "number" &&
currentActivePosition !== this.currentActivePosition &&
!this.items[this.currentActivePosition].disabled
) {
Expand Down