Skip to content

fix(list-item): adds border between grouped and ungrouped list-items #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 18, 2023
Merged

fix(list-item): adds border between grouped and ungrouped list-items #8134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3a5420
fix(list-item): adds border between grouped and ungrouped list-items
anveshmekala Nov 6, 2023
550a9fe
fix border when filtered
anveshmekala Nov 8, 2023
0ca9e21
fixes margin when filtered items are not part of a group
anveshmekala Nov 10, 2023
cc38984
refactor
anveshmekala Nov 17, 2023
b616246
feedback changes
anveshmekala Nov 17, 2023
0127331
remove margin top for first item in group
anveshmekala Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/calcite-components/calcite-preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export default {
"2-lg": "0 12px 32px -2px rgba(0, 0, 0, 0.1), 0 4px 20px 0 rgba(0, 0, 0, 0.08)",
"2-sm": "0 2px 12px -4px rgba(0, 0, 0, 0.2), 0 2px 4px -2px rgba(0, 0, 0, 0.16)",
"border-bottom": "0 1px 0 var(--calcite-ui-border-3)",
"border-top": "0px -1px 0 var(--calcite-ui-border-3)",
"outline-active": "0 0 0 1px var(--calcite-ui-brand)",
none: "none",
xs: "0 0 0 1px rgba(0, 0, 0, 0.05)",
Expand Down
5 changes: 3 additions & 2 deletions packages/calcite-components/src/components/list-item-group/list-item-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@
}

::slotted(calcite-list-item) {
@apply shadow-border-bottom mb-px;
@apply shadow-border-top;
margin-block-start: 1px;
}

::slotted(calcite-list-item:last-child) {
::slotted(calcite-list-item:first-child) {
@apply shadow-none;
}

Expand Down
5 changes: 3 additions & 2 deletions packages/calcite-components/src/components/list/list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@
}

::slotted(calcite-list-item) {
@apply shadow-border-bottom mb-px;
@apply shadow-border-top;
margin-block-start: 1px;
}

::slotted(calcite-list-item:last-child) {
::slotted(calcite-list-item:first-child) {
@apply shadow-none;
}

Expand Down