fix(input-time-zone): fix error caused by time zone group filtering #7971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
p - high
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
Merged
benelan
added a commit
that referenced
this pull request
Oct 11, 2023
* origin/main: (83 commits) chore: add design tokens to monorepo (#7948) test(input-time-zone): restore common tests (#7963) chore: release next fix(input-time-zone): fix error caused by time zone group filtering (#7971) chore: release next fix(table): Improve scrollbar display (#7967) build: bump timezone-groups (#7962) chore: release next fix(flow-item): update collapsed property when collapse button is clicked (#7960) chore: release main (#7945) chore: release next fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947) fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954) chore(deps): update calcite-ui-icons to 3.24.7 (#7949) test(flow-item, panel): add tests for internal property. (#7931) chore: release next fix(panel): fix collapse action title and reverse icon direction (#7927) chore: update issue template labels to support workflows (#7938) build(deps): bump timezone-groups (#7933) build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925) ...
geospatialem
pushed a commit
that referenced
this pull request
Oct 12, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.9.2</summary> ## [1.9.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-12) ### Bug Fixes * **flow-item:** Update collapsed property when collapse button is clicked ([#7960](#7960)) ([f6fd55f](f6fd55f)) * **input-time-zone:** Allow searching offsets by Etc/x time zone ([#7978](#7978)) ([2c34b42](2c34b42)) * **input-time-zone:** Fix error caused by time zone group filtering ([#7971](#7971)) ([521673e](521673e)) * **table:** Improve scrollbar display ([#7967](#7967)) ([593a1bf](593a1bf)) </details> <details><summary>@esri/calcite-components-react: 1.9.2</summary> ## [1.9.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-12) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.9.2-next.3 to ^1.9.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7944
Summary
Addresses an issue caused by time zone label index adjustment (from time zone group filtering) ended up as -1 and cause an error when using it as a lookup index.
This also adds missing tests from #7947.