-
Notifications
You must be signed in to change notification settings - Fork 80
feat(pagination): enable responsive layout #7722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
ff7a52f
8590507
557a99e
60018d6
02001d3
99699d8
30970f8
3a74f56
7c78a0a
46b3317
6dc2eff
2202292
ab5df5f
359ca00
162ec9a
f8ff5b2
1c0e028
fc8cab6
9cb2ede
3bae98c
acce18b
2e49d1e
33b68b1
7805062
49ba934
7c6ad89
7451947
cae3e4d
4f71301
1c5bce8
2234f6e
0ee18d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
interface Breakpoints { | ||
export interface Breakpoints { | ||
width: { | ||
large: number; | ||
medium: number; | ||
|
@@ -17,6 +17,8 @@ function breakpointTokenToNumericalValue(style: CSSStyleDeclaration, tokenName: | |
* This util will return a breakpoints lookup object. | ||
* | ||
* Note that the breakpoints will be evaluated at the root and cached for reuse. | ||
* | ||
* @returns {Promise<Breakpoints>} The Breakpoints object. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we were no longer adding types via JSDoc and relying solely on TypeScript. cc @benelan There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My linter always tells me to do this and I do not argue. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Always wise not to argue with linters. 🤜💥 Serious talk, we disabled There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jcfranco do we have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I was about to disable |
||
*/ | ||
export async function getBreakpoints(): Promise<Breakpoints> { | ||
if (getBreakpointsPromise) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, I like this very much. We could add a util to make it easier to create all the necessary breakpoint stories across components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah a util would be nice here 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a stab at this to help with the rest of the responsive component work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. I think ill wait for it to be merged to update it here.