Skip to content

fix(panel): Allow panel content to take full height. #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 4, 2023
Merged

fix(panel): Allow panel content to take full height. #7454

merged 10 commits into from
Aug 4, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Aug 4, 2023 •
edited
Loading

Related Issue: #7453

Summary

  • Combine wrapper and container nodes/classes to simplify implementation.
  • Fixes full height content for children of panel
  • It seems that the <section> isn't necessary.
  • Add stories

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Aug 4, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 4, 2023
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 4, 2023
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 4, 2023
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 4, 2023
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 4, 2023
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 4, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 4, 2023
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 4, 2023
@driskull driskull marked this pull request as ready for review August 4, 2023 21:01
@driskull driskull requested a review from a team as a code owner August 4, 2023 21:01
@driskull driskull changed the title fix(panel): Fix panel display issue. fix(panel): Allow panel content to take full height. Aug 4, 2023
@driskull driskull requested a review from asangma August 4, 2023 21:02
jcfranco
jcfranco approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Awesome job on the improved screenshot coverage. 📸

@driskull driskull merged commit b6bf54f into main Aug 4, 2023
@driskull driskull deleted the dris0000/fix-panel-display branch August 4, 2023 21:46
@github-actions github-actions bot added this to the 1.5.1 patch - Bugs only milestone Aug 4, 2023
@calcite-admin calcite-admin mentioned this pull request Aug 4, 2023
Merged
benelan pushed a commit that referenced this pull request Aug 8, 2023
@calcite-admin @github-actions
chore: release main (#7447)
aaa6c6b 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.5.1</summary>

##
[1.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2023-08-08)


### Bug Fixes

* **accordion:** Restore accordion-items working with accordion across
shadow DOM
([#7466](#7466))
([bedb5db](bedb5db))
* **action-bar, action-pad:** Add native tooltip to expand action
([#7452](#7452))
([9673ef7](9673ef7))
* Fix SSR build error caused by browser-sniffing util
([#7461](#7461))
([e5381fa](e5381fa))
* **flow-item:** Use a native tooltip for the back button
([#7442](#7442))
([f38167b](f38167b))
* **input:** Fix clearable from throwing an error when value is
undefined
([#7476](#7476))
([633c2cd](633c2cd))
* **list:** Add missing drag handle locale strings
([#7462](#7462))
([2b5463e](2b5463e))
* **panel:** Add native tooltip to close button.
([#7434](#7434))
([70b45cf](70b45cf))
* **panel:** Allow panel content to take full height.
([#7454](#7454))
([b6bf54f](b6bf54f))
* **panel:** Correct header and action-bar z-indexing display issues
([#7440](#7440))
([db7eac7](db7eac7))
* **slider:** Numbers remain on one line for locales with space group
separators
([#7472](#7472))
([2747b22](2747b22))
</details>

<details><summary>@esri/calcite-components-react: 1.5.1</summary>

##
[1.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2023-08-08)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.5.1-next.4 to ^1.5.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

@asangma asangma Awaiting requested review from asangma

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
1.5.1 patch - Bugs only
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco