feat(navigation, navigation-logo, navigation-user): Add navigation, navigation-logo & navigation-user components. #6873
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # calcite-menu-item | ||
|
|
||
| <!-- Auto Generated Below --> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # calcite-menu | ||
|
|
||
| <!-- Auto Generated Below --> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { Component, Element, h, Host, Prop, VNode } from "@stencil/core"; | ||
| import { CSS } from "./resources"; | ||
|
|
||
| @Component({ | ||
| tag: "calcite-navigation-logo", | ||
| styleUrl: "navigation-logo.scss", | ||
| shadow: { | ||
| delegatesFocus: true | ||
| } | ||
| }) | ||
| export class CalciteNavigationLogo { | ||
| //-------------------------------------------------------------------------- | ||
| // | ||
| // Element | ||
| // | ||
| //-------------------------------------------------------------------------- | ||
| @Element() el: HTMLCalciteNavigationLogoElement; | ||
|
|
||
| //-------------------------------------------------------------------------- | ||
| // | ||
| // Public Properties | ||
| // | ||
| //-------------------------------------------------------------------------- | ||
| /** When true, the component is highlighted. */ | ||
anveshmekala marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @Prop({ reflect: true }) active: boolean; | ||
|
|
||
| /** Specifies the URL destination of the component, which can be set as an absolute or relative path.*/ | ||
| @Prop({ reflect: true }) href: string; | ||
|
|
||
| /** Describes the appearance or function of the `thumbnail`. If no label is provided, context will not be provided to assistive technologies. */ | ||
| @Prop() label: string; | ||
|
|
||
| /** Specifies the subtext to display, such as an organization or application description. */ | ||
| @Prop() subtext: string; | ||
|
There was a problem hiding this comment. Should this maybe be named There was a problem hiding this comment. we can use description here considering we change the cc @jcfranco There was a problem hiding this comment. changed to heading and description. Wondering if we should drop |
||
|
|
||
| /** Specifies the text to display, such as a product name.*/ | ||
| @Prop() text: string; | ||
|
|
||
| /** When `true`, displays the `text` and `subText` contents. */ | ||
| @Prop({ reflect: true }) textEnabled = false; | ||
|
|
||
| /** Specifies the `src` to an image. */ | ||
| @Prop() thumbnail: string; | ||
|
|
||
| // -------------------------------------------------------------------------- | ||
anveshmekala marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // | ||
| // Render Methods | ||
| // | ||
| // -------------------------------------------------------------------------- | ||
|
|
||
| render(): VNode { | ||
| return ( | ||
| <Host> | ||
| <a href={this.href} tabindex={0}> | ||
|
There was a problem hiding this comment. No need to set There was a problem hiding this comment. the tabIndex still needs to be set here because the default 0 is applied only when href has a valid value or an empty string. I tried adding empty string which results in reload of page. Later changed to "#" which affects a11y instructions. There was a problem hiding this comment. Maybe you could do There was a problem hiding this comment.
There was a problem hiding this comment. Should we add There was a problem hiding this comment. If that's the case, it should probably follow There was a problem hiding this comment. i don't think There was a problem hiding this comment. I think it would just be a11y concerns. An anchor should take you somewhere (either on the page or off) whereas as button should perform some action. There was a problem hiding this comment. when href is The only time VoiceOver recognizes logo as Tested with VoicOver and safari 16.4 There was a problem hiding this comment. synced-up with kitty today. Updates regarding navigation-logo a11y:
|
||
| {this.thumbnail && <img alt={this.label || ""} src={this.thumbnail} />} | ||
| {(this.text || this.subtext) && this.textEnabled && ( | ||
anveshmekala marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <div class={CSS.textContainer}> | ||
| {this.text && ( | ||
| <span class={CSS.logoText} key={CSS.logoText}> | ||
| {this.text} | ||
| </span> | ||
| )} | ||
| {this.subtext && ( | ||
| <span class={CSS.logoSubtext} key={CSS.logoSubtext}> | ||
| {this.subtext} | ||
| </span> | ||
| )} | ||
| </div> | ||
| )} | ||
| </a> | ||
| </Host> | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { accessible, defaults, hidden, reflects, renders } from "../../tests/commonTests"; | ||
|
|
||
| describe("calcite-navigation-logo", () => { | ||
| describe("renders", () => { | ||
| renders("calcite-navigation-logo", { display: "inline-flex" }); | ||
| }); | ||
|
|
||
| describe("honors hidden attribute", () => { | ||
| hidden("calcite-navigation-logo"); | ||
| }); | ||
|
|
||
| describe("accessible", () => { | ||
| accessible("calcite-navigation-logo"); | ||
| }); | ||
|
|
||
anveshmekala marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| it("reflects", () => | ||
| reflects("calcite-navigation-logo", [ | ||
| { | ||
| propertyName: "active", | ||
| value: "true" | ||
| }, | ||
| { | ||
| propertyName: "href", | ||
| value: "#logo" | ||
| }, | ||
| { | ||
| propertyName: "textEnabled", | ||
| value: "true" | ||
| } | ||
| ])); | ||
|
|
||
| it("defaults", async () => | ||
| defaults("calcite-navigation-logo", [ | ||
| { | ||
| propertyName: "textEnabled", | ||
| defaultValue: false | ||
| } | ||
| ])); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| :host { | ||
| @apply inline-flex outline-none; | ||
| & a { | ||
| @apply flex | ||
| m-0 | ||
| items-center | ||
| justify-center | ||
| cursor-pointer | ||
| transition-default | ||
| focus-base | ||
| no-underline; | ||
| border-block-end: 2px solid transparent; | ||
| } | ||
| & img { | ||
| @apply flex h-7 m-0; | ||
| } | ||
| } | ||
|
|
||
| a:hover, | ||
| a:focus { | ||
| @apply bg-foreground-2; | ||
| } | ||
|
|
||
| a:focus { | ||
| @apply focus-inset; | ||
| } | ||
|
|
||
| a:active { | ||
| @apply bg-foreground-3; | ||
| } | ||
|
|
||
| img { | ||
| padding-inline: 1rem; | ||
| } | ||
|
|
||
| img ~ .text-container { | ||
| @apply ps-0; | ||
| } | ||
|
|
||
| :host(:active) a { | ||
| @apply text-color-1; | ||
| } | ||
|
|
||
| :host([active]) a { | ||
| @apply text-color-1; | ||
| border-color: var(--calcite-ui-brand); | ||
| --calcite-ui-icon-color: var(--calcite-ui-brand); | ||
| } | ||
|
|
||
| .text-container { | ||
| @apply flex | ||
| flex-col | ||
| truncate | ||
| text-start; | ||
| padding-inline: 1rem; | ||
| } | ||
|
|
||
| .logo-text { | ||
| @apply text-0 | ||
| ms-0 | ||
| truncate | ||
| text-color-1 | ||
| font-medium; | ||
| margin-block-start: 2px; | ||
| } | ||
|
|
||
| .logo-subtext { | ||
| @apply text-color-2 truncate; | ||
| font-size: var(--calcite-font-size--1); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { boolean, storyFilters } from "../../../.storybook/helpers"; | ||
| import { placeholderImage } from "../../../.storybook/placeholderImage"; | ||
| import readme from "./readme.md"; | ||
| import { html } from "../../../support/formatting"; | ||
| import { text } from "@storybook/addon-knobs"; | ||
|
|
||
| export default { | ||
| title: "Components/Navigation/Navigation Logo", | ||
| parameters: { | ||
| notes: readme | ||
| }, | ||
| ...storyFilters() | ||
| }; | ||
|
|
||
| export const simple = (): string => | ||
| html`<calcite-navigation-logo | ||
| subtext="${text("subtext", "City of AcmeCo")}" | ||
| text="${text("text", "ArcGIS Online")}" | ||
| thumbnail="${placeholderImage({ width: 50, height: 50 })}" | ||
| ${boolean("active", false)} | ||
| ${boolean("text-enabled", true)} | ||
| />`; | ||
|
|
||
| export const text_TestOnly = (): string => html`<calcite-navigation-logo text="ArcGIS Online" text-enabled />`; | ||
|
|
||
| export const subtext_TestOnly = (): string => | ||
| html`<calcite-navigation-logo | ||
| subtext="City of AcmeCo" | ||
| text-enabled | ||
| thumbnail="${placeholderImage({ width: 50, height: 50 })}" | ||
| />`; | ||
|
|
||
| export const thumbnail_TestOnly = (): string => | ||
| html`<calcite-navigation-logo thumbnail="${placeholderImage({ width: 50, height: 50 })}" />`; | ||
|
|
||
| export const textAndThumbnail_TestOnly = (): string => html`<calcite-navigation-logo | ||
| text="ArcGIS Online" | ||
| thumbnail="${placeholderImage({ width: 50, height: 50 })}" | ||
| text-enabled | ||
| />`; | ||
|
|
||
| export const subtextAndThumbnail_TestOnly = (): string => html`<calcite-navigation-logo | ||
| subtext="City of AcmeCo" | ||
| thumbnail="${placeholderImage({ width: 50, height: 50 })}" | ||
| text-enabled | ||
| />`; | ||
|
|
||
| export const All_TestOnly = (): string => html`<calcite-navigation-logo | ||
| text="ArcGIS Online" | ||
| subtext="City of AcmeCo" | ||
| thumbnail="${placeholderImage({ width: 50, height: 50 })}" | ||
| text-enabled | ||
| />`; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is related to visual regression found while debugging navigation component.