Skip to content

feat: add global CSS props for focus offset and color #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 14, 2023

Related Issue: #3392

Summary

Adds the following global CSS props:

  • --calcite-ui-focus-color
  • --calcite-ui-focus-offset-invert – inverts the applied offset when set to 1 or keeps as is when 0

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 14, 2023
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 14, 2023
@jcfranco jcfranco marked this pull request as ready for review April 21, 2023 23:43
@jcfranco jcfranco requested a review from a team as a code owner April 21, 2023 23:43
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 21, 2023
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧘‍♂️ excellent

--calcite-panel-width-multiplier: 1;
--calcite-ui-focus-color: var(--calcite-ui-brand);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc @geospatialem for inclusion when we add / improve css var and token docs

@jcfranco jcfranco merged commit fbe7b20 into master Apr 24, 2023
@jcfranco jcfranco deleted the jcfranco/3392-add-global-css-focus-props branch April 24, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants