Skip to content

docs(accordion-item): add actions-start and actions-end slots #6631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

geospatialem
Copy link
Member

Related Issue: #6561

Summary

Add accordions actions-start and actions-end slots. 🎰

@geospatialem geospatialem requested a review from a team as a code owner March 22, 2023 16:11
@geospatialem geospatialem self-assigned this Mar 22, 2023
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Mar 22, 2023
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be for accordion-item right?

@geospatialem
Copy link
Member Author

This should be for accordion-item right?

Eeek, good catch! Updating now.

@geospatialem geospatialem marked this pull request as draft March 22, 2023 16:32
@geospatialem geospatialem changed the title docs(accordion): add actions-start and actions-end slots docs(accordion-item): add actions-start and actions-end slots Mar 22, 2023
@geospatialem geospatialem marked this pull request as ready for review March 22, 2023 17:25
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @geospatialem and good catch @macandcheese 🎉

@geospatialem geospatialem merged commit bcf349e into master Mar 22, 2023
@geospatialem geospatialem deleted the geospatialem/6561-docs-accordion-item-slots branch March 22, 2023 21:45
benelan added a commit that referenced this pull request Mar 23, 2023
…roup-sep

* origin/master:
  docs(accordion-item): add actions-start and actions-end slots (#6631)
  docs(modal): kebab-case slot names and sticky context (#6625)
  chore(release): 1.1.1-next.1
  fix: restore form control validation in Safari (#6623)
  chore(linting): fix linting errors (#6613)
  build(deps): Bump eslint-plugin-react from 7.31.11 to 7.32.2 (#6619)
  build(deps): Bump eslint from 8.35.0 to 8.36.0 (#6620)
  build(deps): Bump @types/lodash-es from 4.17.6 to 4.17.7 (#6621)
benelan added a commit that referenced this pull request Mar 27, 2023
…ocus-revert

* origin/master: (30 commits)
  fix(modal): prevent error when calling setFocus on a recently rendered and opened modal (`dist-custom-elements`) (#6666)
  fix(tile-select): fix click not firing in custom-elements build (#6665)
  fix(card): provide more meaningful screen reader label for selectable cards (deprecates `deselect` message override) (#6657)
  fix(pagination): add current page information for screen readers (#6637)
  chore: update jsbin sample to CC 1.0 breaking changes and latest jsapi version (#6651)
  feat(text-area): add calcite-text-area component (#5644)
  chore(release): 1.1.1-next.2
  fix(tile): adds styling to `tile` where `link` is present for additional distinction (#6628)
  docs(input, input-number, input-text): api consistency across components (#6634)
  docs(accordion-item): add actions-start and actions-end slots (#6631)
  docs(modal): kebab-case slot names and sticky context (#6625)
  chore(release): 1.1.1-next.1
  fix: restore form control validation in Safari (#6623)
  chore(linting): fix linting errors (#6613)
  build(deps): Bump eslint-plugin-react from 7.31.11 to 7.32.2 (#6619)
  build(deps): Bump eslint from 8.35.0 to 8.36.0 (#6620)
  build(deps): Bump @types/lodash-es from 4.17.6 to 4.17.7 (#6621)
  build: fix peer dependency resolution error (#6611)
  ci: update user-defined priority (#6609)
  build: update browserslist db (#6527)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation updates only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants