fix(inline-editable, input-message, input-number, input-text, input): prevent components from unintentionally picking up a different scale/status value from an ancestor #6506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove legacy prop lookup behavior for non-child components
github-actions
bot
added
the
bug
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
|
@joeyHarig Thanks for bringing this back on my radar. 😅 I'll get this updated and it should be available in the April release. |
…r-for-non-child-components
|
Thanks for the update @jcfranco! |
jcfranco
removed
the
Stale
jcfranco
changed the title
jcfranco
added
the
pr ready for visual snapshots
…r-for-non-child-components
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/remove-legacy-prop-lookup-behavior-for-non-child-components
branch
github-actions
bot
added this to the 2023 April Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6494
Summary
This PR updates remaining non-children components to no longer look up their ancestry to set props.