fix(tabs): fix error when tabs is resized before initial render #6342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
eriklharper
approved these changes
Jan 30, 2023
jcfranco
deleted the
jcfranco/6310-fix-error-when-tab-nav-is-resized-before-initial-render
branch
github-actions
bot
added this to the 2023 February Priorities - No breaking changes milestone
|
Could it be that the bot did something wrong with the adding to "2023 February Priorities - No breaking changes"? |
geospatialem
modified the milestones:
2023 February Priorities - No breaking changes ,
2023 January Priorities Patch - Bugs only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6310
Summary
This prevents resize logic from running if the indicator element has not been rendered and stored internally.
Note: I originally added an E2E test for this case, but I have not been able to make it fail.