Skip to content

docs(flow-item): make showBackButton internal #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Dec 27, 2022

Related Issue: #6178

Summary

Makes the showBackButton property used by the parent flow internal

@benelan benelan requested a review from a team as a code owner December 27, 2022 18:30
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Dec 27, 2022
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* When `true`, displays a back button in the component's header.
*
* @internal
*/
@Prop({ reflect: true }) showBackButton = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update it to not reflect?

@benelan benelan merged commit 2fe424b into master Dec 28, 2022
@benelan benelan deleted the benelan/6178-flow-item-internal-prop branch December 28, 2022 18:52
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 28, 2022
benelan added a commit that referenced this pull request Dec 28, 2022
* master:
  chore(notice): Remove invalid kind values (#6186)
  1.0.0-next.703
  build(deps): update dependencies. (#6189)
  refactor(pagination)!: Remove css variable (#6183)
  docs: consistent slot messaging across components (#6190)
  docs(flow-item): make showBackButton internal (#6179)
  ci(chromatic): set higher diffThreshold and delay for unstable tests (#6180)
  build(deps): bump storybook from 6.5.14 to 6.5.15 (#6176)
  build(deps): bump @typescript-eslint/eslint-plugin from 5.47.0 to 5.47.1 (#6175)
  build(deps): bump @storybook/addon-docs from 6.5.14 to 6.5.15 (#6174)
  docs: update component READMEs (#6184)
  build(deps): bump calcite-ui-icons from 3.20.5 to 3.20.7 (#6170)
  build(deps): bump @typescript-eslint/parser from 5.45.1 to 5.47.1 (#6177)
  1.0.0-next.702
  fix(date-picker): modify weekStart value for ar locale (#6154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation updates only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants