Skip to content

fix(split-button): Fix duplicate border when href is set #11976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

macandcheese
Copy link
Contributor

Related Issue: #11909

Summary

Fix for duplicate border - there was a <button> style set in Button without a corresponding <a> style.
Adds local demo and Chromatic tests.

Before After
Screenshot 2025-04-17 at 9 43 31 AM Screenshot 2025-04-17 at 9 43 53 AM

@macandcheese macandcheese changed the title Macandcheese/11909 fix split href fix(split-button): Fix duplicate border when href is set Apr 17, 2025
@macandcheese macandcheese changed the title fix(split-button): Fix duplicate border when href is set fix(split-button): Fix duplicate border when href is set Apr 17, 2025
@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 17, 2025
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 17, 2025
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 17, 2025
Copy link

@SkyeSeitz SkyeSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual changes look g2g! 🚀

@macandcheese macandcheese merged commit 6942c21 into dev Apr 17, 2025
14 checks passed
@macandcheese macandcheese deleted the macandcheese/11909-fix-split-href branch April 17, 2025 21:28
benelan added a commit that referenced this pull request Apr 17, 2025
…vent

* origin/dev:
  fix(split-button): Fix duplicate border when `href` is set (#11976)
benelan pushed a commit that referenced this pull request May 14, 2025
**Related Issue:** #11909 

## Summary
Fix for duplicate border - there was a `<button>` style set in Button
without a corresponding `<a>` style.
Adds local demo and Chromatic tests.

| Before    | After |
| -------- | ------- |
| ![Screenshot 2025-04-17 at 9 43
31 AM](https://github.com/user-attachments/assets/75ed4114-6951-4357-bdd9-eca572fa9256)
| ![Screenshot 2025-04-17 at 9 43
53 AM](https://github.com/user-attachments/assets/69cf5a25-e432-4897-ade8-b5175fc8c5f2)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants