fix(input-date-picker): allow clearing invalid date value #11937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
| const input = await page.find("calcite-input-date-picker >>> calcite-input-text"); | ||
| await inputDatePicker.callMethod("setFocus"); | ||
| await inputDatePicker.type(inputValue); | ||
| await inputDatePicker.press("Escape"); |
There was a problem hiding this comment.
Nitpick: Don't think this is required. Applies to all other tests.
| const oldValue = this._value; | ||
| if (value !== oldValue) { | ||
| const valueChanged = value !== this._value; | ||
| const invalidValueCleared = value === "" && this.startInput?.value !== ""; |
There was a problem hiding this comment.
If the user skip setting startInput & set an invalid value in endInput value, clearing those values wouldn't work.
anveshmekala
requested changes
Apr 14, 2025
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/10169-allow-clearing-intermediate-invalid-date-value
branch
benelan
added a commit
that referenced
this pull request
Apr 17, 2025
…gis-deps * origin/dev: (31 commits) chore: add workflow manager to team issue templates (#11971) chore: release next feat(accordion-item): enhance component's interactivity states (#11935) chore: release next build(deps): update dependency lerna to v8.2.2 (#11948) feat(switch): enhance component's colors for a11y and usability (#11951) chore: release next ci: remove redundant test mode environment variable (#11958) fix(input-date-picker): allow clearing invalid date value (#11937) build: update browserslist db (#11946) feat(notice): add token for close icon and title text color (#11938) fix(list, block-group): fix drag handle events when lists or blocks are nested (#11816) chore: release next build(deps): update dependency vite to v5.4.18 (#11949) ci: default to stable tests when experimental mode is not set (#11957) fix(input-number): cancel arrow down event (#11956) refactor: tidy up (#11945) docs(checkbox): update icon color prop context (#11950) build(deps): bump node minor version (#11927) chore: release next ...
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10169
Summary
Fixes issue where clearing the value failed if input was invalid/incomplete and not committed.