Skip to content

docs: update README.md #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

docs: update README.md #11767

merged 2 commits into from
Mar 19, 2025

Conversation

arowles
Copy link
Contributor

@arowles arowles commented Mar 19, 2025 •
edited by github-actions bot
Loading

Reverts #11765

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE

@calcite-admin calcite-admin added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 19, 2025
@arowles arowles changed the title Revert "fix: Update README.md" "fix: Revert Update README.md" Mar 19, 2025
@arowles arowles requested a review from allieorth March 19, 2025 20:24
@arowles
Copy link
Contributor Author

arowles commented Mar 19, 2025

@allieorth we accidentally deleted the new link instead of the old one, so I reverted the last merge and added the correct link

@arowles arowles changed the title "fix: Revert Update README.md" fix: Revert Update README.md Mar 19, 2025
@arowles arowles changed the title fix: Revert Update README.md Revert fix: Update README.md Mar 19, 2025
@arowles arowles changed the title Revert fix: Update README.md fix: Update README.md Mar 19, 2025
@arowles arowles requested review from allieorth and removed request for allieorth March 19, 2025 20:27
@arowles arowles merged commit 5a4204c into dev Mar 19, 2025
13 of 16 checks passed
@arowles arowles deleted the revert-11765-arowles-patch-1 branch March 19, 2025 20:29
benelan added a commit that referenced this pull request Mar 24, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into 6646-advanced-table
cdd2bc3 
* origin/dev: (61 commits)
  build(deps): update dependency stylelint to v16.16.0 (#11784)
  build(deps): update dependency type-fest to v4.37.0 (#11785)
  chore: release next
  build(deps): update eslint (#11786)
  docs: update list of contributors (#11780)
  feat(combobox-item): add component tokens (#11645)
  chore: release next
  feat: add browser join and browser plus (#11779)
  build(deps): update storybook monorepo to v8.6.6 (#11763)
  build(deps): update dependency lint-staged to v15.5.0 (#11764)
  docs: update list of contributors (#11769)
  build: update browserslist db (#11773)
  chore: release next
  feat(combobox, combobox-item-group): add component tokens (#11623)
  fix: Update README.md (#11768)
  fix: Update README.md (#11767)
  fix: Update README.md (#11765)
  revert(menu-item): revert hover state interaction changes (#11761)
  refactor(filter): remove unused styles (#11758)
  chore: use Vite for `@esri/eslint-plugin-calcite-components` build (#11752)
  ...
benelan added a commit that referenced this pull request Mar 24, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/10237-lumina-m…
b2a5da8 
…igration-ssr

* origin/dev: (278 commits)
  build(deps): update storybook monorepo to v8.6.7 (#11783)
  build: update browserslist db (#11792)
  build(deps): update dependency stylelint to v16.16.0 (#11784)
  build(deps): update dependency type-fest to v4.37.0 (#11785)
  chore: release next
  build(deps): update eslint (#11786)
  docs: update list of contributors (#11780)
  feat(combobox-item): add component tokens (#11645)
  chore: release next
  feat: add browser join and browser plus (#11779)
  build(deps): update storybook monorepo to v8.6.6 (#11763)
  build(deps): update dependency lint-staged to v15.5.0 (#11764)
  docs: update list of contributors (#11769)
  build: update browserslist db (#11773)
  chore: release next
  feat(combobox, combobox-item-group): add component tokens (#11623)
  fix: Update README.md (#11768)
  fix: Update README.md (#11767)
  fix: Update README.md (#11765)
  revert(menu-item): revert hover state interaction changes (#11761)
  ...
benelan pushed a commit that referenced this pull request Mar 26, 2025
@arowles @benelan
fix: Update README.md (#11767)
1550fb1 
Reverts #11765
@calcite-admin calcite-admin mentioned this pull request Mar 26, 2025
Merged
@benelan
Copy link
Member

benelan commented Mar 26, 2025 •
edited
Loading

@arowles @allieorth in the future can you please make sure there are changes before approving/merging pull requests?

For reference, you can confirm in the Files changed tab below the PR title:
image

It looks like there were no changes in #11765 either, so I recommend checking the current version of README.md to make sure it looks correct.

Also, when changing the readme, can you please use the docs type for the pull request title? For example: docs: update readme.

Let me know if you have any questions, thanks!

@benelan benelan added the no changelog entry Use the commit override to avoid a changelog entry label Mar 26, 2025
@benelan benelan changed the title fix: Update README.md Update README.md Mar 26, 2025
@benelan benelan changed the title Update README.md docs: update README.md Mar 26, 2025
@jcfranco
Copy link
Member

Also, when changing the readme, can you please use the docs type for the pull request title? For example: docs: update readme.

I've found this cheatsheet very helpful.

@arowles
Copy link
Contributor Author

arowles commented Mar 26, 2025

@arowles @allieorth in the future can you please make sure there are changes before approving/merging pull requests?

For reference, you can confirm in the Files changed tab below the PR title: image

It looks like there were no changes in #11765 either, so I recommend checking the current version of README.md to make sure it looks correct.

Also, when changing the readme, can you please use the docs type for the pull request title? For example: docs: update readme.

Let me know if you have any questions, thanks!

Hi Ben, I will definitely do that next time. I was initially not sure if docs was the right tag for this pull request. For this pull request I was updating the hyperlink in this part of the readme
image

It was originally pointing to a doc that is located on the old and now archived calcite-ui repo and we wanted it to exist in the wiki docs in the calcite-desgn-system repo and to also correct a spelling error within the doc.

benelan pushed a commit that referenced this pull request May 14, 2025
@arowles @benelan
fix: Update README.md (#11767)
e625568 
Reverts #11765
@calcite-admin calcite-admin mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allieorth allieorth allieorth approved these changes

Assignees

@arowles arowles

Labels
no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

Successfully merging this pull request may close these issues.
5 participants
@arowles @benelan @jcfranco @allieorth @calcite-admin