Skip to content

fix(stepper-item): keep initial focus on newly selected item #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2025
Merged

fix(stepper-item): keep initial focus on newly selected item #11482

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a7e9fa
fix(stepper-item): keep initial focus on newly selected item
jcfranco Feb 7, 2025
9bb4e1e
guard against unset layout prop in items
jcfranco Feb 7, 2025
79f551f
simplify tabindex layout condition
jcfranco Feb 7, 2025
476b4e7
restore explainer comment
jcfranco Feb 7, 2025
0301d29
add test
jcfranco Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/calcite-components/src/components/stepper-item/stepper-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ export class StepperItem extends LitElement implements InteractiveComponent, Loa

override updated(): void {
updateHostInteraction(this);
setAttribute(
this.el,
"tabindex",
this.disabled || this.layout.includes("horizontal") ? null : 0,
);
}

loaded(): void {
Expand Down Expand Up @@ -327,7 +332,6 @@ export class StepperItem extends LitElement implements InteractiveComponent, Loa
/* TODO: [MIGRATION] This used <Host> before. In Stencil, <Host> props overwrite user-provided props. If you don't wish to overwrite user-values, replace "=" here with "??=" */
this.el.ariaCurrent = this.selected ? "step" : "false";
/* TODO: [MIGRATION] This used <Host> before. In Stencil, <Host> props overwrite user-provided props. If you don't wish to overwrite user-values, add a check for this.el.hasAttribute() before calling setAttribute() here */
setAttribute(this.el, "tabIndex", this.disabled ? -1 : 0);

// use local var to bypass logic-changing compiler transformation
const innerDisplayContextTabIndex = this.layout === "horizontal" && !this.disabled ? 0 : null;
Expand Down
Loading