Skip to content

feat(chip): deprecate pressed in favor of press #11389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2025
Merged

feat(chip): deprecate pressed in favor of press #11389

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76cfe7d
chore(chip): deprecate pressed
alisonailea Jan 27, 2025
204211d
Merge branch 'dev' of github.com:Esri/calcite-design-system into astu…
alisonailea Feb 12, 2025
9b74d20
fix(chip): missing variable applied
alisonailea Feb 12, 2025
1540461
chore(chip): sort token docs alphabetically
alisonailea Feb 12, 2025
ce34fc0
test(chip): update e2e, demo, and custom-theme pages
alisonailea Feb 12, 2025
aecf35e
fix(chip): [deprecate] should be [Deprecated]
alisonailea Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/calcite-components/src/components/chip/chip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
* @prop --calcite-chip-icon-color: Specifies the component's icon color.
* @prop --calcite-chip-close-icon-color: Specifies the component's close element icon color.
* @prop --calcite-chip-select-icon-color: Specifies the component's selection element icon color.
* @prop --calcite-chip-select-icon-color-pressed: Specifies the component's selection element icon color when active.
* @prop --calcite-chip-select-icon-color-pressed: [deprecate] Use `--calcite-chip-select-icon-color-press`. Specifies the component's selection element icon color when active.
* @prop --calcite-chip-select-icon-color-press: Specifies the component's selection element icon color when active.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisonailea it doesn't look like this new var is used anywhere? Should there also be tests here?

*
*/

Expand Down
Loading