Skip to content

chore(t9n): rename message files #11054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Dec 13, 2024

Related Issue: #11081

Summary

  • Updates filenames of message files in each component. New specification follow message.lang.json format.
  • Removes util:sync-t9n-en-bundles script.
  • Update t9nmanifest.txt files with updated path.

Related to https://devtopia.esri.com/WebGIS/arcgis-web-components/discussions/1522

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 13, 2024
@anveshmekala anveshmekala changed the title chore(t9n): rename message files chore(t9n): renames message files Dec 14, 2024
@jcfranco jcfranco changed the title chore(t9n): renames message files chore(t9n): rename message files Dec 16, 2024
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 17, 2024
@anveshmekala anveshmekala marked this pull request as ready for review December 17, 2024 00:55
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝
📝📂📝📝📝📂📝📝📂📂📝📝📂📂📂📝📝📂📂📂📝📂📂📂📂📝📂📝
📝📂📂📝📝📂📝📂📝📝📂📝📝📂📝📝📂📝📝📝📝📂📝📝📝📝📂📝
📝📂📝📂📝📂📝📂📝📝📂📝📝📂📝📝📂📝📝📝📝📂📂📂📝📝📂📝
📝📂📝📝📂📂📝📂📝📝📂📝📝📂📝📝📂📝📝📝📝📂📝📝📝📝📝📝
📝📂📝📝📝📂📝📝📂📂📝📝📂📂📂📝📝📂📂📂📝📂📂📂📂📝📂📝
📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 17, 2024
@anveshmekala anveshmekala merged commit f7250e1 into dev Dec 17, 2024
17 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/chore-t9n-file-rename branch December 17, 2024 05:30
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 17, 2024
jcfranco added a commit that referenced this pull request Jan 7, 2025
…ions.json` (#11219)

**Related Issue:** #10731

## Summary

Updates `generateT9nDocsJSON.ts` to reference the updated translations
bundle file name (see
#11054).
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:**
#11081

## Summary

- Updates filenames of message files in each component. New
specification follow `message.lang.json` format.
- Removes `util:sync-t9n-en-bundles` script.
- Update `t9nmanifest.txt` files with updated path.

Related to
https://devtopia.esri.com/WebGIS/arcgis-web-components/discussions/1522

---------

Co-authored-by: JC Franco <[email protected]>
benelan pushed a commit that referenced this pull request Feb 8, 2025
…ions.json` (#11219)

**Related Issue:** #10731

## Summary

Updates `generateT9nDocsJSON.ts` to reference the updated translations
bundle file name (see
#11054).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants