Skip to content

Panel: footer-end should appear at the end #9857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
driskull opened this issue Jul 25, 2024 · 3 comments
Closed
2 of 6 tasks

Panel: footer-end should appear at the end #9857

driskull opened this issue Jul 25, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-07-31 - Jul ...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

footer-end slot appears centered if there is no footer-start slot

Expected Behavior

footer-end should always appear at the end

Reproduction Sample

https://codepen.io/driskull/pen/yLdawGa?editors=1010

Reproduction Steps

  1. open the codepen
  2. notice how the slotted button is centered instead of at the end
  3. uncomment the footer-start slotted button
  4. Notice how it now looks correctly

Reproduction Version

2.10.1

Relevant Info

No response

Regression?

No

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 25, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jul 25, 2024
@jcfranco jcfranco added p - high Issue should be addressed in the current milestone, impacts component or core functionality 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jul 25, 2024
@jcfranco jcfranco added this to the 2024-08-27 - Aug Release milestone Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@jcfranco jcfranco removed the 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. label Jul 25, 2024
@driskull driskull mentioned this issue Jul 26, 2024
Merged
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 29, 2024
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 29, 2024
driskull added a commit that referenced this issue Jul 29, 2024
@driskull
fix(panel): correct footer padding and layout (#9868)
b25a0ae 
**Related Issue:** #9858 #9857

## Summary

- fixes footer-end slot alignment when its the only thing slotted
- refactor styles
- makes footer slot take precedence over the other footer slots
(including deprecated footer-actions)
- add screenshot tests
- cleanup screenshot tests
@driskull driskull added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 29, 2024

🍡 Verified locally on dev
image

@DitwanP DitwanP closed this as completed Jul 29, 2024
@DitwanP DitwanP added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Jul 29, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@driskull @github-actions
fix(panel): correct footer padding and layout (#9868)
1e02ece 
**Related Issue:** #9858 #9857

## Summary

- fixes footer-end slot alignment when its the only thing slotted
- refactor styles
- makes footer slot take precedence over the other footer slots
(including deprecated footer-actions)
- add screenshot tests
- cleanup screenshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @DitwanP