-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Labels
4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Issues that have been tested, confirmed as mitigated, and are ready to close.ArcGIS Maps SDK for JavaScriptIssues logged by ArcGIS SDK for JavaScript team members.Issues logged by ArcGIS SDK for JavaScript team members.bugBug reports for broken functionality. Issues should include a reproduction of the bug.Bug reports for broken functionality. Issues should include a reproduction of the bug.calcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.estimate - 5A few days of work, definitely requires updates to tests.A few days of work, definitely requires updates to tests.impact - p3 - not time sensitiveUser set priority impact status of p3 - not time sensitiveUser set priority impact status of p3 - not time sensitivep - mediumIssue is non core or affecting less that 60% of people using the libraryIssue is non core or affecting less that 60% of people using the library
Milestone
Description
Check existing issues
- I have checked for existing issues to avoid duplicates
Actual Behavior
When the <calcite-sheet>
is opened, its calciteSheetBeforeOpen event is fired only after the transition/animation has happened.
Expected Behavior
As per the documentation the event should be fired before the transition starts, and calciteSheetOpen should be called after it finishes.
Reproduction Sample
https://codepen.io/hccampos/pen/pomLvZo
Reproduction Steps
- Open https://codepen.io/hccampos/pen/pomLvZo
- Click "Open sheet"
- Notice that when the alert is displayed, the transition is already completed.
Reproduction Version
2.9.x
Relevant Info
No response
Regression?
No response
Priority impact
impact - p3 - not time sensitive
Impact
No response
Calcite package
- @esri/calcite-components
- @esri/calcite-components-angular
- @esri/calcite-components-react
- @esri/calcite-design-tokens
- @esri/eslint-plugin-calcite-components
Esri team
ArcGIS Maps SDK for JavaScript
Metadata
Metadata
Assignees
Labels
4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Issues that have been tested, confirmed as mitigated, and are ready to close.ArcGIS Maps SDK for JavaScriptIssues logged by ArcGIS SDK for JavaScript team members.Issues logged by ArcGIS SDK for JavaScript team members.bugBug reports for broken functionality. Issues should include a reproduction of the bug.Bug reports for broken functionality. Issues should include a reproduction of the bug.calcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.estimate - 5A few days of work, definitely requires updates to tests.A few days of work, definitely requires updates to tests.impact - p3 - not time sensitiveUser set priority impact status of p3 - not time sensitiveUser set priority impact status of p3 - not time sensitivep - mediumIssue is non core or affecting less that 60% of people using the libraryIssue is non core or affecting less that 60% of people using the library