Skip to content

List: when programmatically opening a list-item that is closed, borders are not present #9248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
driskull opened this issue May 2, 2024 · 2 comments
Closed
2 of 6 tasks

List: when programmatically opening a list-item that is closed, borders are not present #9248

driskull opened this issue May 2, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2024-05-28 - May ...

Comments

@driskull
Copy link
Member

driskull commented May 2, 2024

Check existing issues

Actual Behavior

when programmatically opening a list-item that is closed, borders are not present

Expected Behavior

when programmatically opening a list-item that is closed, borders are present

Reproduction Sample

https://codepen.io/driskull/pen/RwOzKLj?editors=1000

Reproduction Steps

  1. open the codepen
  2. wait one second for the first list item to be opened
  3. notice the nested list items don't have border when they should

Reproduction Version

2.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 2, 2024
@driskull driskull self-assigned this May 2, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 2, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels May 2, 2024
@driskull driskull added this to the 2024-05-28 - May Main Release milestone May 2, 2024
@driskull driskull added estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone and removed needs triage Planning workflow - pending design/dev review. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels May 2, 2024
@driskull driskull mentioned this issue May 2, 2024
Merged
driskull added a commit that referenced this issue May 3, 2024
@driskull
fix(list): border items when an item is programmatically opened. (#9247)
02183bb 
**Related Issue:** #9248

## Summary

- Use internal event on list-item to emit whenever `open` property
changes
- Listen for internal event on the list to update bordering.
@driskull driskull added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull May 3, 2024
@DitwanP
Copy link
Contributor

DitwanP commented May 13, 2024

🍡 Verified on 2.9.0-next.4

@DitwanP DitwanP closed this as completed May 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP