Skip to content

Action: Create localized template for aria-label #9071

Closed
@driskull

Description

@driskull

Check existing issues

Actual Behavior

aria-label is using a template for its string value here

const ariaLabel = `${label || text}${indicator ? ` (${messages.indicator})` : ""}`;

Expected Behavior

This should use a proper localized template

Reproduction Sample

https://codepen.io/driskull/pen/NWmyeXw?editors=1000

Reproduction Steps

  1. open codepen
  2. Inspect internal element with aria-label aria-label="test (Indicator present)"

Reproduction Version

1.7.1

Relevant Info

#9051 (comment)

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

Metadata

Metadata

Labels

4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.a11yIssues related to Accessibility fixes or improvements.bugBug reports for broken functionality. Issues should include a reproduction of the bug.calcite-componentsIssues specific to the @esri/calcite-components package.estimate - 1Very small fix or change (potentially a single line), doesn't require updates to tests.good first issueIssues that can be worked on by contributors new to calcite-components.i18n-l10nissues dealing with internationalization/localizationimpact - p3 - not time sensitiveUser set priority impact status of p3 - not time sensitivep - mediumIssue is non core or affecting less that 60% of people using the library

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions