-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Labels
4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Issues that have been tested, confirmed as mitigated, and are ready to close.calcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.estimate - 2Small fix or update, may require updates to tests.Small fix or update, may require updates to tests.refactorIssues tied to code that needs to be significantly reworked.Issues tied to code that needs to be significantly reworked.
Milestone
Description
Description
All sass mixin/function/vars/placeholder names should be kebab case for consistency and to follow Sass naming rules.
- https://sass-lang.com/documentation/at-rules/mixin/
- https://sass-lang.com/documentation/variables/
- https://sass-lang.com/documentation/style-rules/placeholder-selectors/
- https://sass-lang.com/documentation/at-rules/function/
E.g.,
@mixin calciteHydratedHidden()
=>@mixin calcite-hydrated-hidden()
Additionally, the following stylelint-scss
rules should be enabled to enforce this naming convention:
- https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-function-pattern/README.md
- https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/at-mixin-pattern/README.md
- https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-pattern/README.md
- https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/percent-placeholder-pattern/README.md
Proposed Advantages
development consistency
Which Component
All components
Relevant Info
Calcite package
- @esri/calcite-components
- @esri/calcite-components-react
Metadata
Metadata
Assignees
Labels
4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Issues that have been tested, confirmed as mitigated, and are ready to close.calcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.estimate - 2Small fix or update, may require updates to tests.Small fix or update, may require updates to tests.refactorIssues tied to code that needs to be significantly reworked.Issues tied to code that needs to be significantly reworked.