Skip to content

[Menu Item] - When in parent vertical menu, icon-end is in the wrong position #7097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
macandcheese opened this issue Jun 2, 2023 · 2 comments
Closed

[Menu Item] - When in parent vertical menu, icon-end is in the wrong position #7097

macandcheese opened this issue Jun 2, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
2023 June patch p...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jun 2, 2023 •
edited
Loading

Actual Behavior

Currently, if a Menu Item within a parent menu in "vertical" layout has slotted children, and an icon-end, the position of the icons will be incorrect:

Screen Shot 2023-06-02 at 9 52 47 AM

Expected Behavior

The icon-end should be in the correct position:

Screen Shot 2023-06-02 at 9 51 47 AM

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/oNaKoOo?editors=1000

Reproduction Steps

  1. Visit sample
  2. Notice the "trucks" menu item has the incorrect order

Reproduction Version

1.4.2

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 2, 2023
@macandcheese macandcheese self-assigned this Jun 2, 2023
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 2, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 2, 2023
@macandcheese macandcheese mentioned this issue Jun 2, 2023
Merged
macandcheese added a commit that referenced this issue Jun 2, 2023
@macandcheese
fix(menu-item): Ensure correct order of rendered icons (#7098)
fd344e9 
**Related Issue:** #7097 

## Summary
Updates the rendered order of icons, updates local demo, adds screenshot
test.
@macandcheese macandcheese added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 2 - in development Issues that are actively being worked on. labels Jun 2, 2023
@github-actions github-actions bot assigned geospatialem and unassigned macandcheese Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed needs triage Planning workflow - pending design/dev review. 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Jun 2, 2023
@geospatialem
Copy link
Member

Verified in 1.4.3-next.1

image

benelan added a commit that referenced this issue Jun 27, 2023
@calcite-admin @github-actions @benelan
chore: release latest (#7144)
2422120 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.4.3</summary>

##
[1.4.3](https://github.com/Esri/calcite-components/compare/@esri/[email protected]...@esri/[email protected])
(2023-06-26)

### Bug Fixes

* **accordion-item:** support items working across shadowDOM ([#7035](#7035)) ([6378e35](6378e35)), closes [#6167](#6167)
* **alert:** Sets autoCloseDuration to "medium" by default
([#7157](#7157))
([1b9a8ed](1b9a8ed))
* **alert:** Update alert queue when an alert is removed from the DOM
([#7189](#7189))
([edd59eb](edd59eb))
* **combobox, dropdown, input-date-picker, input-time-picker, popover,
tooltip:** Prevent repositioning from affecting other floating
components
([#7178](#7178))
([1b02dae](1b02dae))
* Ensure mouse events are blocked for disabled components in Firefox
([#7107](#7107))
([271d985](271d985))
* **input-date-picker:** Fix showing the placeholder when resetting the
value ([#7156](#7156))
([8d60ffd](8d60ffd))
* **input, input-number:** Allows numeric characters.
([#7213](#7213))
([739f0af](739f0af))
* **input,input-number:** Allow typing decimal separator in firefox for
arabic locale
([#7173](#7173))
([595e6f2](595e6f2))
* **list:** No longer has incorrect border width
([a810943](a810943))
* **list:** Update selectedItems property on all item selection changes
([#7204](#7204))
([da048f6](da048f6))
* **menu-item:** Ensure correct order of rendered icons ([#7098](#7098)) ([fd344e9](fd344e9)), closes [#7097](#7097)

* **navigation:** Label is no longer a required property
([#7084](#7084))
([ba2bd4d](ba2bd4d))
* **radio-button-group:** No longer focus first radio button on label
click and adds `setFocus` method.
([#7050](#7050))
([4267b8c](4267b8c))
* **radio-button, radio-button-group:** Prevent emitting events when
selecting a checked radio button
([#7102](#7102))
([77fcc81](77fcc81))
* **radio-button:** Focuses first focusable radio-button element in
group. ([#7152](#7152))
([dd7ec60](dd7ec60))
* **scrim:** Responsively set the scale of the loading spinner
([#7182](#7182))
([72c5943](72c5943))
* **tooltip:** Improve component timing
([#7172](#7172))
([106f5d2](106f5d2))
* **tree-item:** Ensure expanded tree-item is displayed when expanded
and made visible
([#7216](#7216))
([3c0fbf5](3c0fbf5))

<details><summary>@esri/calcite-components-react: 1.4.3</summary>

##
[1.4.3](https://github.com/Esri/calcite-components/compare/@esri/[email protected]...@esri/[email protected])
(2023-06-26)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 1.4.3-next.7 to 1.4.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
2 participants
@macandcheese @geospatialem