fix(input-time-picker): only load valid dayjs locale files and fallback to base lang when region code is unsupported #7049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck to base lang when region code is unsupported
github-actions
bot
added
the
bug
jcfranco
approved these changes
May 26, 2023
…ted locale is being properly fetched
eriklharper
added
the
pr ready for visual snapshots
geospatialem
modified the milestones:
Design Sprint 2023/05/29 - 2023/06/09,
1.4.1 May patch - Bugs only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7040
Summary
This fixes an issue where setting
langto a locale code with an unsupported region (e.g.nl-nl) failed to fall back to the base language and didn't render the component.