Skip to content

Input-time-picker does not accept normal locale (nl-nl) code anymore #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arjanvanzutphen opened this issue May 26, 2023 · 2 comments
Closed

Input-time-picker does not accept normal locale (nl-nl) code anymore #7040

arjanvanzutphen opened this issue May 26, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members regression Issues that are caused by changes in a release, but were working before that.
Milestone
1.4.1 May patch -...

Comments

@arjanvanzutphen
Copy link

Actual Behavior

The input time picker does not get rendered with the same lang property value as in 1.3.0.
The behavior looks this bug: #7036

Changing the locale value from 'nl-nl' to 'nl' works.

Expected Behavior

Expecting to see a input time picker with the lang property set to 'nl-nl'

Reproduction Sample

Codepen of the input-time-picker sample from https://developers.arcgis.com/calcite-design-system/components/input-time-picker/

Reproduction Steps

  1. Go to the input time picker page: https://developers.arcgis.com/calcite-design-system/components/input-time-picker/
  2. Go to it's codepen sample
  3. Add lang='nl-nl' property to the input-time-picker web component
  4. The input-time-picker does not get rendered
  5. Console errors a missing file. nl-nl.js is missing in dayjs, because it's now nl.js
  6. Changing the lang property to 'nl' makes the input-time-picker appear again

Reproduction Version

1.4.0

Relevant Info

Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: https://js.arcgis.com/calcite-components/1.4.0/assets/input-time-picker/nls/dayjs/locale/nl-nl.js

Regression?

1.3.0

Priority impact

p3 - want for upcoming milestone

Impact

No response

Esri team

Professional Services - Services Delivery
@arjanvanzutphen arjanvanzutphen added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 26, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members labels May 26, 2023
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 26, 2023
@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. labels May 26, 2023
@eriklharper eriklharper mentioned this issue May 26, 2023
Merged
eriklharper added a commit that referenced this issue May 27, 2023
@eriklharper
fix(input-time-picker): only load valid dayjs locale files and fallba…
d6a99d5 
…ck to base lang when region code is unsupported (#7049)

**Related Issue:** #7040

## Summary

This fixes an issue where setting `lang` to a locale code with an
unsupported region (e.g. `nl-nl`) failed to fall back to the base
language and didn't render the component.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels May 27, 2023
@github-actions github-actions bot assigned geospatialem and unassigned eriklharper May 27, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels May 27, 2023
@geospatialem
Copy link
Member

Verified in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

No branches or pull requests
4 participants
@jcfranco @eriklharper @geospatialem @arjanvanzutphen