Skip to content

[Navigation] label property is required even if navigationAction is disabled #7013

Closed
@mpayson

Description

@mpayson

Actual Behavior

The label property is typed as required, but it is only used to label the navigation action, so it shouldn't be required when the navigation action is disabled. cc @macandcheese

Expected Behavior

The label property is optional

Reproduction Sample

https://github.com/Esri/calcite-components/blob/master/src/components/navigation/navigation.tsx#L56

Reproduction Steps

See typings and doc description

Reproduction Version

1.4.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Esri team

ArcGIS Online

Metadata

Metadata

Assignees

Labels

4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.ArcGIS OnlineIssues logged by ArcGIS Online team members.bugBug reports for broken functionality. Issues should include a reproduction of the bug.impact - p3 - not time sensitiveUser set priority impact status of p3 - not time sensitive

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions