Skip to content

Closed date picker popup requires tabbing out and back in to be reopened #6773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcfranco opened this issue Apr 12, 2023 · 7 comments
Closed

Closed date picker popup requires tabbing out and back in to be reopened #6773

jcfranco opened this issue Apr 12, 2023 · 7 comments
Assignees
@geospatialem @SkyeSeitz @yelenakreyndel @ashetland
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to, or during, development. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ready for dev Issues ready for development implementation.
Milestone
2023 April Priori...

Comments

@jcfranco
Copy link
Member

jcfranco commented Apr 12, 2023 •
edited by geospatialem
Loading

Actual Behavior

Closing a date picker via Escape force a user to tab outside and back into the component to display again.

Expected Behavior

An affordance in the picker to toggle the popup (akin to combobox) and adding support to reopen on ⬇️ key press.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/input-date-picker/

Reproduction Steps

  1. Click sandbox above input
  2. Press Tab
  3. Picker popup opens
  4. Press Escape
  5. Picker closes

Once closed, the picker can no longer be opened unless users tab outside and back in

Reproduction Version

1.2.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 12, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 12, 2023
@jcfranco jcfranco mentioned this issue Apr 12, 2023
Closed
@geospatialem geospatialem added design Issues that need design consultation prior to, or during, development. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 13, 2023
@jcfranco jcfranco mentioned this issue Apr 14, 2023
Closed
@geospatialem
Copy link
Member

Design implementation will follow combobox. Routing to development. cc @ashetland @jcfranco

@geospatialem geospatialem added ready for dev Issues ready for development implementation. and removed design Issues that need design consultation prior to, or during, development. labels Apr 17, 2023
@geospatialem geospatialem assigned jcfranco and unassigned ashetland Apr 17, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 17, 2023
@jcfranco jcfranco mentioned this issue Apr 18, 2023
Merged
@ashetland
Copy link
Contributor

cc @SkyeSeitz for Figma updates

@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Apr 21, 2023
jcfranco added a commit that referenced this issue Apr 21, 2023
@jcfranco
feat(input-date-picker): allow toggling date picker by clicking the i…
233c22b 
…nput or entering the down/escape key (#6805)

**Related Issue:** #6773 

## Summary

This enhances the input-date-picker to allow it to be toggled via mouse
and keyboard vs initial focus.

This also updates input to allow overriding role to accommodate other
a11y structures.
@jcfranco jcfranco added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels Apr 21, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Apr 21, 2023
@geospatialem
Copy link
Member

Verified on master via mouse, keyboard and AT - Windows JAWS and NVDA.

cc @SkyeSeitz @ashetland - once we're good on Figma changes, can close out the issue.

@ashetland
Copy link
Contributor

ashetland commented Apr 21, 2023 •
edited
Loading

Did the PR add anything to Input Time Picker or just Input Date Picker? This issue title implies both, but I think the work I reviewed only included Input Date Picker.

@geospatialem geospatialem mentioned this issue Apr 22, 2023
Closed
@geospatialem geospatialem changed the title Closed time/date picker popups require tabbing out and back in to be reopened Closed date picker popup requires tabbing out and back in to be reopened Apr 22, 2023
@geospatialem
Copy link
Member

Did the PR add anything to Input Time Picker or just Input Date Picker? This issue title implies both, but I think the work I reviewed only included Input Date Picker.

@ashetland - Good catch. Refactored this issue to date-picker, and opened #6830 to tackle the time picker effort. The design should be the same for both components.

@geospatialem
Copy link
Member

Figma changes are noted - closing out this issue.

@jcfranco jcfranco mentioned this issue Sep 16, 2023
Merged
@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
@brittneytewks brittneytewks added the design Issues that need design consultation prior to, or during, development. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@yelenakreyndel yelenakreyndel

@ashetland ashetland

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to, or during, development. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 April Priorities - No breaking c...
Development

No branches or pull requests
6 participants
@jcfranco @geospatialem @SkyeSeitz @yelenakreyndel @ashetland @brittneytewks