Skip to content

stepper : numbering-system displaying inconsistent results with two stepper components in a page #6331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anveshmekala opened this issue Jan 24, 2023 · 2 comments
Closed

stepper : numbering-system displaying inconsistent results with two stepper components in a page #6331

anveshmekala opened this issue Jan 24, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. i18n-l10n issues dealing with internationalization/localization needs triage Planning workflow - pending design/dev review.
Milestone
2023 January Prio...

Comments

@anveshmekala
Copy link
Contributor

anveshmekala commented Jan 24, 2023 •
edited
Loading

Actual Behavior

if two numbered stepper components are rendered in a page with different numbering-system, when user alternate the clicks between stepper components the numbers are showing inconsistent results.

Expected Behavior

stepper components should follow numbering-system defined on them or should fall back to latn numbers.

Reproduction Sample

https://codepen.io/ANVESHMEKALA/pen/YzjaveB?editors=100

Reproduction Steps

  1. Click on the stepper item with arabic numbers
  2. Then, click on the stepper item above with latin numbers
  3. Observe that latin numbers changes to arabic.

Reproduction Version

next.729

Relevant Info

No response

Regression?

beta.97

Impact

No response

Esri team

N/A
@anveshmekala anveshmekala added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 24, 2023
@anveshmekala anveshmekala self-assigned this Jan 27, 2023
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 27, 2023
This was referenced Jan 30, 2023
Merged
Closed
anveshmekala added a commit that referenced this issue Jan 31, 2023
@anveshmekala
fix(stepper-item): no longer refer numberingSystem from neighbor step…
c647fe3 
…per component (#6380)

**Related Issue:** #6331 

## Summary

This PR will fix the issue of `stepper` component's numbers being
localized to the `numberingSystem` specified by neighboring `stepper`
component rendered in same page.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels Jan 31, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Jan 31, 2023
@geospatialem
Copy link
Member

Verified in 1.0.4-next.5

@annierm18 annierm18 added the i18n-l10n issues dealing with internationalization/localization label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. i18n-l10n issues dealing with internationalization/localization needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
2023 January Priorities Patch - Bugs ...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @annierm18 @anveshmekala