fix(date-picker): modify weekStart value for ar locale #6154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
geospatialem
added
the
pr ready for visual snapshots
geospatialem
added
pr ready for visual snapshots
benelan
added a commit
that referenced
this pull request
Dec 28, 2022
* master: chore(notice): Remove invalid kind values (#6186) 1.0.0-next.703 build(deps): update dependencies. (#6189) refactor(pagination)!: Remove css variable (#6183) docs: consistent slot messaging across components (#6190) docs(flow-item): make showBackButton internal (#6179) ci(chromatic): set higher diffThreshold and delay for unstable tests (#6180) build(deps): bump storybook from 6.5.14 to 6.5.15 (#6176) build(deps): bump @typescript-eslint/eslint-plugin from 5.47.0 to 5.47.1 (#6175) build(deps): bump @storybook/addon-docs from 6.5.14 to 6.5.15 (#6174) docs: update component READMEs (#6184) build(deps): bump calcite-ui-icons from 3.20.5 to 3.20.7 (#6170) build(deps): bump @typescript-eslint/parser from 5.45.1 to 5.47.1 (#6177) 1.0.0-next.702 fix(date-picker): modify weekStart value for ar locale (#6154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
Summary
Previously, date-picker had the weekStart value as "7" for the locale "ar", when it's actual weekStart as returned by intl object is "6". JSAPI team asked for the weekStart to be changed to "6" so that the week start day for the "ar" locale can be consistent across Esri web products.