Skip to content

Accordion's selection mode can become stale #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nwhittaker opened this issue Aug 12, 2022 · 2 comments
Closed

Accordion's selection mode can become stale #5143

nwhittaker opened this issue Aug 12, 2022 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
2023 January Prio...

Comments

@nwhittaker
Copy link
Contributor

Actual Behavior

Given a <calcite-accordion selection-mode="single">, then dynamically changing its selection-mode to multi, the user is unable to expand multiple sections.

Expected Behavior

Given a <calcite-accordion selection-mode="single">, then dynamically changing its selection-mode to multi, the user is able to expand multiple sections.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/JjLaVNB

Reproduction Steps

  1. Visit the sample and note the accordion behaves in accordance with the "single" selection mode.
  2. Click the Multi selection button and use dev tools to inspect the accordion and note it now has "multi" selection mode.
  3. Attempt to expand more than one accordion section and note that the previously expanded section auto-collapses.

Reproduction Version

beta.91

Relevant Info

Toggling the selection-mode is convenient for re-purposing the accordion for different states. Specifically, Field Maps could use an accordion to show different groups of layers one-at-a-time. But, when the user enters some text to filter by, we want to expand all the sections and show the matching layers.

Regression?

No response
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 12, 2022
@nwhittaker nwhittaker changed the title Accordion's selection behavior can become stale Accordion's selection mode can become stale Aug 16, 2022
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Aug 23, 2022
@driskull driskull assigned driskull and unassigned driskull Dec 17, 2022
@anveshmekala anveshmekala self-assigned this Jan 26, 2023
@anveshmekala anveshmekala mentioned this issue Jan 26, 2023
Merged
@anveshmekala anveshmekala removed the 0 - new New issues that need assignment. label Jan 26, 2023
@anveshmekala anveshmekala added the 2 - in development Issues that are actively being worked on. label Jan 26, 2023
anveshmekala added a commit that referenced this issue Jan 30, 2023
@anveshmekala
fix(accordion): supports selection mode updates (#6356)
8278d3e 
**Related Issue:** #5143 

## Summary

This PR will allow user to switch `selection-mode` and the items expand
accordingly.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels Jan 30, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Jan 30, 2023
@geospatialem
Copy link
Member

Verified in 1.0.4-next.3 with the following Codepen sample.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
2023 January Priorities Patch - Bugs ...
Development

No branches or pull requests
6 participants
@jcfranco @nwhittaker @driskull @geospatialem @benelan @anveshmekala