-
Notifications
You must be signed in to change notification settings - Fork 80
Opening modal immediately after hydration yields inconsistent transitions #5067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks like the initial transition is skipped entirely because the host is initially rendered as end state (host initially rendered w/ |
There may be some confusion on my part around when an element is considered rendered relative to when it is considered hydrated. I understand if there's no transition when |
Reallocating this issue to the February priorities milestone. |
Finally getting back to this. 😅 When a component is hydrated, it means it has finished lazy-loading its implementation and has been initially rendered. Setting #6564 should help keep all of modal's transitions in sync. |
**Related Issue:** #5067 ## Summary Moves an internal open state class to the topmost container so all transitions are in sync.
Installed and assigned for verification. |
Actual Behavior
Once a
calcite-modal
element becomes hydrated, setting theopen
attribute causes the modal's backdrop to appear abruptly while the dialog area transitions in smoothly.Expected Behavior
The modal's backdrop also transitions in smoothly.
Reproduction Sample
https://codepen.io/nwhittaker-esri/pen/qBoxdgg
Reproduction Steps
It may be helpful to use Chrome's Animations tab to slow down the transitions.
Reproduction Version
beta.86
Relevant Info
A workaround is to wait about .5s after hydration before setting
open
to produces the expected result.In Ember it's typical to render the
<calcite-modal>
element at the time it needs to open (ideally w/out a delay).open
is set after hydration because setting it initially currently has a couple drawbacks:active
#4764Regression?
No response
The text was updated successfully, but these errors were encountered: