Skip to content

fix(shell-panel): handle overflow scrolling #12069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

driskull
Copy link
Member

@driskull driskull commented Apr 30, 2025

Related Issue: #12057

Summary

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 30, 2025
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 30, 2025
@driskull driskull requested a review from macandcheese April 30, 2025 18:35
@driskull driskull marked this pull request as ready for review April 30, 2025 18:35
@driskull driskull merged commit 9d5764e into dev Apr 30, 2025
17 checks passed
@driskull driskull deleted the dris0000/shell-panel-size-2 branch April 30, 2025 19:16
benelan pushed a commit that referenced this pull request May 14, 2025
**Related Issue:** #12057

## Summary

- add full width and height to container
- add screenshot test
- repro test case: https://codepen.io/driskull/pen/xbbPBwN?editors=1000
- Notice how the center bottom shell panel isn't positioned or
overflowing correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants