Skip to content

[notice] close icon variable unexpectedly changes the title text color #11790

@matgalla

Description

@matgalla

Check existing issues

Actual Behavior

Customizing notice's --calcite-notice-close-text-color-hover variable changes the color of both the close icon's hover and the title text.

Image

The variable is also named -close-text

Expected Behavior

  • The variable only should only change the close icon hover color
  • The variable should be named --calcite-notice-close-icon-color-hover
  • The title text should have it's own, new color variable: --calcite-notice-title-text-color
  • Same for the message text: --calcite-notice-message-text-color

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/emYrKQx?editors=100

Reproduction Steps

  1. Visit notice sample: https://developers.arcgis.com/calcite-design-system/components/notice/#sample
  2. Enable closable prop
  3. Customize the --calcite-notice-close-text-color-hover variable

Reproduction Version

v3.0.3

Relevant Info

Chrome on MacOS/Windows/Android and Firefox on Windows

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

Metadata

Metadata

Labels

4 - verifiedIssues that have been tested, confirmed as mitigated, and are ready to close.Calcite (design)Issues logged by Calcite designers.bugBug reports for broken functionality. Issues should include a reproduction of the bug.calcite-design-tokensIssues specific to the @esri/calcite-design-tokens package.design-tokensIssues requiring design tokens.estimate - 2Small fix or update, may require updates to tests.impact - p3 - not time sensitiveUser set priority impact status of p3 - not time sensitive

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions