[dialog] overflow: hidden gets removed when closing dialog even if another dialog is still opened #11408
Description
Check existing issues
- I have checked for existing issues to avoid duplicates
Actual Behavior
If there are two dialogs opened, when you close the first one it immediately removes overflow: hidden from the <html> tag even though another dialog is still opened.
Expected Behavior
overflow: hidden should remain on <html> tag if there's still an opened dialog
Reproduction Sample
https://codepen.io/rpanichakit/pen/VYZgRrm?editors=1000
Reproduction Steps
- Open the codepen URL
- Inspect the HTML to see the
overflow: hiddenpresent on the<html>tag inside the iframe in codepen - Close the dialog, and inspect again to see
overflow: hiddenis now removed, even though another dialog is still opened.
Reproduction Version
2.13.2
Relevant Info
No response
Regression?
No response
Priority impact
impact - p3 - not time sensitive
Impact
https://devtopia.esri.com/WebGIS/arcgis-metadata-editor/issues/1536
This happens in a real workflow when the main workflow is inside a dialog and then from that UI, the user can trigger another dialog like confirmation of an action.
Calcite package
- @esri/calcite-components
- @esri/calcite-components-react
- @esri/calcite-design-tokens
- @esri/calcite-ui-icons
- @esri/eslint-plugin-calcite-components
Esri team
ArcGIS Online
Metadata
Metadata
Assignees
Labels
Issues that have been tested, confirmed as mitigated, and are ready to close.Issues logged by ArcGIS Online team members.Bug reports for broken functionality. Issues should include a reproduction of the bug.A day or two of work, likely requires updates to tests.User set priority impact status of p3 - not time sensitiveIssue is non core or affecting less that 60% of people using the library