fix(docs): use updated translation bundle paths to generate translations.json
#11219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
no changelog entry
github-actions
bot
added
the
bug
jcfranco
added
the
skip visual snapshots
anveshmekala
reviewed
Jan 7, 2025
| @@ -24,7 +24,7 @@ | |||
| Object.keys(messagesFileMain).forEach((key) => (data[component][key] = {})); | |||
|
|
|||
| const messagesFilenames = (await readdir(t9nPath, { withFileTypes: true })).map((dirent) => dirent.name); | |||
| const messagesFilenameRegex = new RegExp(`${component}\\.t9n\\.(.*)\\.json`); | |||
| const messagesFilenameRegex = new RegExp(`messages\\.(.*)\\.json`); | |||
There was a problem hiding this comment.
Sidenote: should have been caught here #11054.
Is there a way to add a test to assert this?
There was a problem hiding this comment.
Currently, we don’t have tests for our support files/scripts, but we could explore adding something like output snapshot diffing, similar to the design tokens. Open to ideas here. Could you open a follow-up issue for this?
macandcheese
approved these changes
Jan 7, 2025
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Updates
generateT9nDocsJSON.tsto reference the updated translations bundle file name (see #11054).