fix(input): Avoid styling on non-reflected attributes #11089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
macandcheese
added
the
pr ready for visual snapshots
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #10959 #10958 ## Summary Adds classes to use for specific styling cases in Input. This only adjusts `suffix-text` and `prefix-text`. There are other styles set on attributes in the component, but those are reflected attributes. We could still improve that in the future if needed - and / or, in the newer `input-x` components.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10959 #10958
Summary
Adds classes to use for specific styling cases in Input. This only adjusts
suffix-textandprefix-text. There are other styles set on attributes in the component, but those are reflected attributes. We could still improve that in the future if needed - and / or, in the newerinput-xcomponents.Also fixes a selector typo.